Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ usager malvoyant ou ayant des troubles de la lecture, je veux que les champs de formulaires soient exempts d'attribut de présentation #11250

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

inseo
Copy link
Contributor

@inseo inseo commented Jan 24, 2025

Supprime les attributs size interdits sur les champs type="text"

Fix l'issue #11248

Après
Capture d’écran 2025-01-24 à 11 46 45
Capture d’écran 2025-01-24 à 11 51 43

Avant
Capture d’écran 2025-01-24 à 11 31 45
Capture d’écran 2025-01-24 à 11 32 08

Supprime les classes width-33-desktop inutiles

Après
Capture d’écran 2025-01-24 à 15 16 30

Avant
Capture d’écran 2025-01-24 à 15 17 06

@inseo inseo requested a review from LeSim January 24, 2025 10:54
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.40%. Comparing base (11dd700) to head (337468e).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11250      +/-   ##
==========================================
- Coverage   84.41%   84.40%   -0.01%     
==========================================
  Files        1199     1199              
  Lines       26378    26378              
  Branches     4963     4963              
==========================================
- Hits        22266    22265       -1     
- Misses       4112     4113       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -348,19 +348,17 @@
max-width: none;

@media (min-width: $two-columns-breakpoint) {
&:not([size]) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L'attribut size ne doit pas être présent sur les champs de formulaire (à l'exception des champs select) pour des raisons d'accessibilité.

@inseo inseo added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit ea44b33 Jan 27, 2025
18 checks passed
@inseo inseo deleted the a11y-presentation-attr branch January 27, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: En cours
Development

Successfully merging this pull request may close these issues.

2 participants