-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in AuthenticationDialog #463
base: develop
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,6 +23,7 @@ Contributors (and Past Developers): | |
* Pedro Algarvio ('s0undt3ch') <[email protected]> | ||
* Cristian Greco ('cgreco') <[email protected]> | ||
* Chase Sterling ('gazpachoKing') <[email protected]> | ||
* Justin Williams ('Jaywalker') | ||
|
||
Plugin Developers: | ||
* Autoadd : Chase Sterling | ||
|
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -316,7 +316,7 @@ def _on_connect_fail(self, reason, host_id, try_counter): | |||||||||
|
||||||||||
def dialog_finished(response_id): | ||||||||||
if response_id == Gtk.ResponseType.OK: | ||||||||||
self._connect(host_id, dialog.get_username(), dialog.get_password()) | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If AuthenticationDialog methods |
||||||||||
self._connect(host_id, dialog.account.username, dialog.account.password) | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
||||||||||
return dialog.run().addCallback(dialog_finished) | ||||||||||
|
||||||||||
|
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -207,6 +207,8 @@ def __init__(self, err_msg='', username=None, parent=None): | |||||||
parent, | ||||||||
) | ||||||||
|
||||||||
self.account = None | ||||||||
|
||||||||
table = Gtk.Table(2, 2, False) | ||||||||
self.username_label = Gtk.Label() | ||||||||
self.username_label.set_markup('<b>' + _('Username:') + '</b>') | ||||||||
|
@@ -245,6 +247,16 @@ def get_password(self): | |||||||
def on_password_activate(self, widget): | ||||||||
self.response(Gtk.ResponseType.OK) | ||||||||
|
||||||||
def _on_response(self, widget, response): | ||||||||
if response == Gtk.ResponseType.OK: | ||||||||
self.account = Account( | ||||||||
self.username_entry.get_text(), | ||||||||
self.password_entry.get_text(), | ||||||||
"", | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
) | ||||||||
self.destroy() | ||||||||
self.deferred.callback(response) | ||||||||
Comment on lines
+257
to
+258
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I know this was copied from the other dialog but we can make use of super to call the parent class cleanup steps
Suggested change
|
||||||||
|
||||||||
|
||||||||
class AccountDialog(BaseDialog): | ||||||||
def __init__( | ||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list is really for authors of significant contributions to Deluge