[Console] Block interactive-mode on Windows even with curses #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhertz
force-pushed
the
console-winmsg
branch
2 times, most recently
from
75cab75
to
c703ef6
Compare
|
Nothing new btw, never worked on windows in interactive mode with windows-curses. Edit: Python select.select() win32 issue(error 10038), triggered from twisted's selectreactor.py, line 38/100 wrapping said usage(twisted 22.8.0). |
mhertz
changed the title
Hangs after initial opening, so still needs looking into.
doadin
pushed a commit
to doadin/deluge
that referenced
this pull request
Sep 21, 2024
Testing with window-curses results in hangs on initial loading with background error:
File "C:\Users\Docker\Deluge\.venv\lib\site-packages\twisted\internet\selectreactor.py", line 39, in win32select
r, w, e = select.select(r, w, w, timeout)
builtins.OSError: [WinError 10038] An operation was attempted on something that is not a socket
This is due to passing a Console class to addReader but this fails since
select on Windows cannot handle non-socket file object unlike Unix which accepts
sockets and file objects.
There is likely a further issue where windows-curses has not implemented
resizeterm so would need to use resize_term instead.
Refs: https://docs.python.org/3/library/select.html#select.select
Refs: https://stackoverflow.com/questions/11731175/python-twisted-addreader-works-in-linux-but-not-windows
Refs: zephyrproject-rtos/windows-curses#40
Refs: https://docs.python.org/3/library/curses.html#curses.resize_term
Closes: deluge-torrent#457
Co-authored-by: Calum Lind <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hangs after initial opening, so still needs looking into.