Skip to content

Commit

Permalink
[Tests] Fix console tests stalling by pinning pytest to 7.4.2
Browse files Browse the repository at this point in the history
Tests were stalling in deluge_ui_entry with pytest 7.4.3 likely due to
changes in the way it handles stderr but it is not clean the extact
issue.

For now we will pin the pytest version and look to fix the issue later.

Reference: https://docs.pytest.org/en/stable/changelog.html#pytest-7-4-3-2023-10-24
  • Loading branch information
cas-- committed Nov 19, 2023
1 parent 39b9918 commit b2005ec
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- name: Install dependencies
run: |
pip install --upgrade pip wheel setuptools
pip install -r requirements.txt -r requirements-tests.txt
pip install -r requirements-ci.txt
pip install -e .
- name: Install security dependencies
Expand Down Expand Up @@ -92,7 +92,7 @@ jobs:
- name: Install dependencies
run: |
pip install --upgrade pip wheel setuptools
pip install -r requirements.txt -r requirements-tests.txt
pip install -r requirements-ci.txt
pip install -e .
- name: Test with pytest
Expand Down
7 changes: 3 additions & 4 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
[build-system]
requires = [
"setuptools",
"wheel",
]
requires = ["setuptools", "wheel"]

[tool.black]
skip-string-normalization = true
Expand All @@ -11,6 +8,8 @@ skip-string-normalization = true
profile = "black"

[tool.pytest.ini_options]
# Dump tracebacks if a test takes longer than X seconds
faulthandler_timeout = 60
# Hide logged warnings and errors in test output.
log_cli_level = "CRITICAL"
addopts = "--basetemp=_pytest_temp"
Expand Down
4 changes: 4 additions & 0 deletions requirements-ci.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
-r requirements.txt
-r requirements-tests.txt
libtorrent==2.0.7
pytest==7.4.2
2 changes: 1 addition & 1 deletion requirements-tests.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
libtorrent==2.0.7
libtorrent
pytest
pytest-twisted
pytest-cov
Expand Down

0 comments on commit b2005ec

Please sign in to comment.