Skip to content

Commit

Permalink
[Packaging] Fix NSIS Uninstaller Not Removing File\Folder
Browse files Browse the repository at this point in the history
CreateShortCut "$SMPROGRAMS\$StartMenuFolder\Website.lnk" "$INSTDIR\homepage.url"

gets made in the installer but the uninstaller was looking for

 Delete "$SMPROGRAMS\$StartMenuFolder\Deluge Website.lnk"

therefore this file was being left behind and since the folder was not empty

$StartMenuFolder\Deluge

was being left behinde as well.

Closes: #426
  • Loading branch information
doadin authored and cas-- committed May 30, 2023
1 parent d8b586e commit 8001110
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packaging/win/deluge-win-installer.nsi
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,8 @@ Section Uninstall
!insertmacro MUI_STARTMENU_GETFOLDER Application $StartMenuFolder
SetShellVarContext all
Delete "$SMPROGRAMS\$StartMenuFolder\Deluge.lnk"
Delete "$SMPROGRAMS\$StartMenuFolder\Website.lnk"
Delete "$SMPROGRAMS\$StartMenuFolder\Uninstall Deluge.lnk"
Delete "$SMPROGRAMS\$StartMenuFolder\Deluge Website.lnk"
RmDir "$SMPROGRAMS\$StartMenuFolder"
DeleteRegKey /ifempty HKCR "Software\Deluge"

Expand Down

0 comments on commit 8001110

Please sign in to comment.