fix memory leak in ts client. #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old Promises including their return values were not garbage collected, because they were not removed from the `_requests` Map. fixes #60
link2xt
reviewed
Jul 5, 2024
typescript/client.ts
Outdated
| @@ -40,6 +40,7 @@ export abstract class BaseTransport<T = {}> | |||
| if (!handler) return; // TODO: Handle error. | |||
| if (response.error) handler.reject(response.error); | |||
| else handler.resolve(response.result); | |||
| this._requests.delete(response.id) | |||
There was a problem hiding this comment.
Should this be immediately after get(), so handler is removed from the map even if it fails with exception?
Or right after checking for !handler.
link2xt
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old Promises including their return values were not garbage collected, because they were not removed from the
_requestsMap.fixes #60