running prune thread directly in gunicorn #44
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured out a way to run threads from the gunicorn main process. This is a prerequisite for #36. We can use this to run all mailadm threads in the same docker container.
Reference:
I added a small watcher thread which will kill the whole process/container if the prune thread dies. This can be extended to the bot thread when we add it in #23. Also, all our threads are daemon threads - together, this ensures that the whole container dies if any of the gunicorn, prune, or bot threads fails, and can be restarted by docker.
In the long term I want to move the app.prune() function to commands.py or something, but this doesn't exist yet on master, so I just added it to app.py for now. It's a bit against DRY, but let's do this properly after #23 is merged.