Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add russian translation #40

Merged
merged 4 commits into from
Aug 12, 2024
Merged

add russian translation #40

merged 4 commits into from
Aug 12, 2024

Conversation

missytake
Copy link
Contributor

@missytake missytake commented Aug 12, 2024

Can a native speaker take a second look at this?

Also I'm not sure if the localization scheme works at all right now, switching chromium to french already doesn't work for me on main branch, I still see the english text. But tests pass, and updating i18next.js doesn't change anything, so maybe it's fine?

related: #39

@missytake missytake requested a review from link2xt August 12, 2024 12:49
@iequidoo iequidoo self-requested a review August 12, 2024 14:39
i18n/ru.js Outdated Show resolved Hide resolved
@missytake missytake merged commit e78fbc3 into main Aug 12, 2024
2 checks passed
@missytake
Copy link
Contributor Author

@iequidoo Now that it's deployed, can you confirm whether the translation is shown for you?

@missytake missytake deleted the localize-39 branch August 12, 2024 22:04
@iequidoo
Copy link
Contributor

iequidoo commented Aug 13, 2024

i.delta.chat still says "Say hello to iequidoo" while https://delta.chat brings me to https://delta.chat/ru/. FF 115.10.0esr

@rosano
Copy link
Contributor

rosano commented Aug 13, 2024

I'm not sure if it was redirecting before, but I thought it would at least check for preferred language. I can access French https://i.delta.chat/?lang=fr and Russian https://i.delta.chat/?lang=ru with a query parameter.

@iequidoo
Copy link
Contributor

iequidoo commented Aug 13, 2024

Yes, i tried to change my preferred language in FF, but that didn't help for http://i.delta.chat. But if i add ?lang=ru, it works and looks good.

EDIT: Now it works if i change my preferred language, but it looks that FF caches smth so i need to open a "New private window". Not that important i think.

@link2xt
Copy link
Contributor

link2xt commented Aug 13, 2024

Language gets stored into "local storage" by this i18next library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants