do not expect special value for backup transfer progress #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t use the whole range smoothly
r10s
commented
Oct 5, 2024
| } else if permille <= 950 { | ||
| let percent = ((permille-100)*100)/850 | ||
| if permille < 1000 { | ||
| let percent: Int = permille/10 |
There was a problem hiding this comment.
here, permille 0 and 1000 are handled by special booleans 'done' and 'error' above; that could get some streamlining as well, but i wanted to keep this PR on point
link2xt
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'backup' and 'add second device' do not longer have special values but use the whole range smoothly
counterpart of deltachat/deltachat-android#3333