Open i.delta.chat-links in App (#2134) #2295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitschlag
changed the title
r10s
force-pushed
the
2134-open-invite-links-in-app
branch
from
2f7f444
to
bc32b68
Compare
r10s
reviewed
Oct 7, 2024
zeitschlag
force-pushed
the
2134-open-invite-links-in-app
branch
from
bc32b68
to
2f7f444
Compare
This needs some work work, as it's pretty hacky and Console complains.
zeitschlag
force-pushed
the
2134-open-invite-links-in-app
branch
from
2f7f444
to
59146d9
Compare
Thanks to @r10s for pointing this out, I wasn't aware of the fact that core treats QR-code and invitation links equally)
r10s
approved these changes
Oct 9, 2024
All just so that `cancel` in that alert works.
zeitschlag
changed the title
r10s
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users tap on a
i.delta.chatlink in a chat (or in a user's signature), they can start a chat with that very user right away (instead of that Safari opens). Just like this:Pressing on Cancel in that alert just closes the alert. No surprises here.
(The large number of lines comes from moving the QR-handling-code from
QrPageControllertoAppCoordinator)Closes #2134.