improve "Edit Name" dialog #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
force-pushed
the
r10s/improve-edit-name
branch
from
9837657
to
1623e5a
Compare
add placeholder and hints, cleanup layout.
r10s
force-pushed
the
r10s/improve-edit-name
branch
from
f5eaf5a
to
06a6b26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR sets placeholder and footer according to suggestions at #2286
moreover, the title is changed to "Edit Name" and the email address is hidden (as on android/desktop - the dialog focuses on the nickname)
i first tried to follow the way of subclassing NewContactController, however that became even more hacky as before (cells would needed to be var, first reponder check in base class would needed to be changed etc.). not worth few lines of saved code.
therefore, i made
EditContactControllerself-contained and independet. it is 20 lines more, but straight-forward and no hacks so one does not need to check what in the super-class happens all the time.closes #2286
before / after - note the improved placeholder and footer and the general cleanup :)