Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide email in "New chat"-list for trusted contacts #2282

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

zeitschlag
Copy link
Collaborator

@zeitschlag zeitschlag commented Aug 21, 2024

Subtitle-Label gets hidden if chat.isProtected.
I'm not super happy with hiding the subtitleLabel but it's one of two reasonable approaches:

  1. Hide the subtitleLabel
  2. Override the subtitle of the ViewModel to be nil

Another option would have been to cleanup and declutter the ViewModel-stuff but this wouldn't have been pragmatic or reasonable.

Closes #2272.

@zeitschlag zeitschlag requested a review from r10s August 21, 2024 09:25
@zeitschlag zeitschlag self-assigned this Aug 21, 2024
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - and hiding the subtitle makes sense to me as well :)

for the condition, see below, that needs to be tweaked.

deltachat-ios/View/ContactCell.swift Outdated Show resolved Hide resolved
@zeitschlag zeitschlag merged commit ea6d921 into main Aug 26, 2024
1 check passed
@zeitschlag zeitschlag deleted the 2272-no-email-new-chat branch August 26, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove email address from "new chat" screen
2 participants