-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if events must be on main #2253
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitschlag
force-pushed
the
2242-events-on-main
branch
from
August 9, 2024 06:49
eba063f
to
f7bd518
Compare
zeitschlag
force-pushed
the
2242-events-on-main
branch
from
August 9, 2024 06:58
f7bd518
to
12eb037
Compare
"this method is unnecessary and shouldn't be used"
zeitschlag
force-pushed
the
2242-events-on-main
branch
from
August 9, 2024 06:59
12eb037
to
9172e1b
Compare
r10s
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! code lgtm, some minors.
i also did test some standard things and double-checked some "more important" code flows - i did not run into issues yet
great job!
deltachat-ios/Controller/AccountSetup/Instand Onboarding/InstantOnboardingViewController.swift
Show resolved
Hide resolved
Co-authored-by: bjoern <[email protected]>
Just normalising whitespace, thanks @r10s! Co-authored-by: bjoern <[email protected]>
Co-authored-by: bjoern <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More minor refactorings. I checked every notification posted in
events.swift
if posting on main was necessary and it turned out: Most of the stuff gets already handled on main (except one or two, I fixed that).Closes #2242.