feat: localization for logo text alternative #75
+54
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| <Header /> | ||
| <Header | ||
| homepage={{ | ||
| href: '/', |
There was a problem hiding this comment.
Van @savitris begreep ik dat de link in het logo naar de homepage van de gemeente moet gaan, niet naar de homepage van Signalen. En dat het dus ook (voor screenreaders) duidelijk moet zijn naar welke homepage je gaat. Is "homepage" dan voldoende of moet hier ook specifieker staan dat het om de homepage van (in dit geval) Utrecht gaat? En moet er dan ook een melding bij dat je het formulier gaat verlaten?
justiandevs
reviewed
Nov 8, 2024
| label: t('homepage-label'), | ||
| }} | ||
| logo={{ | ||
| src: '/assets/utrecht.webp', |
There was a problem hiding this comment.
| import Image from 'next/image' | ||
|
|
||
| const Header = () => { | ||
| export interface HeaderProps { |
There was a problem hiding this comment.
Vanwaar de keus voor hier een nieuw element toewijzen aan logoElement in plaats van bijvoorbeeld:
const Header = ({ homepage, logo }: HeaderProps) => {
const logoElement = (
<Logo>
<Image src={logo.src} alt={logo.label} width={275} height={150} />
</Logo>
);
return (
<header>
{homepage ? (
<Link boxContent href={homepage.href} aria-labelledby="logo-link-label">
<span id="logo-link-label" hidden>
{homepage.label}
</span>
{logoElement}
</Link>
) : (
logoElement
)}
</header>
);
};
Is dit sneller oid?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.