Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate a bug for schema "validation" when writing JSON to a table #131

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions src/writer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1055,6 +1055,56 @@ mod tests {
use serde_json::json;
use std::path::Path;

#[tokio::test]
async fn test_schema_matching() {
let temp_dir = tempfile::tempdir().unwrap();
let table_path = temp_dir.path();
create_temp_table(table_path);

let table = crate::delta_helpers::load_table(table_path.to_str().unwrap(), HashMap::new())
.await
.unwrap();
let mut writer = DataWriter::for_table(&table, HashMap::new()).unwrap();
let rows: Vec<Value> = vec![json!({
"meta": {
"kafka": {
"offset": 0,
"partition": 0,
"topic": "some_topic"
},
"producer": {
"timestamp": "2021-06-22"
},
},
"twitch": "is the best",
"why" : "does this succeed?!",
// If `some_nested_list` is removed, the Decoder ends up outputing
// an error that gets interpreted as an EmptyRecordBatch
"some_nested_list": [[42], [84]],
"date": "2021-06-22"
})];
let result = writer.write(rows).await;
assert!(
result.is_err(),
"Expected the write of our invalid schema rows to fail!\n{:?}",
result
);
match result {
Ok(_) => unreachable!(),
Err(DataWriterError::SchemaMismatch {
record_batch_schema: _,
expected_schema: _,
}) => {}
Err(e) => {
assert!(
false,
"I was expecting a schema mismatch, got this instead: {:?}",
e
);
}
}
}

#[tokio::test]
async fn delta_stats_test() {
let temp_dir = tempfile::tempdir().unwrap();
Expand Down