[Kernel] Add SUBSTRING expression and default impl
#4001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huan233usc
changed the title
vkorukanti
requested changes
Dec 30, 2024
...defaults/src/main/java/io/delta/kernel/defaults/internal/expressions/SubstringEvaluator.java
Outdated
Show resolved
Hide resolved
...defaults/src/main/java/io/delta/kernel/defaults/internal/expressions/SubstringEvaluator.java
Outdated
Show resolved
Hide resolved
...defaults/src/main/java/io/delta/kernel/defaults/internal/expressions/SubstringEvaluator.java
Outdated
Show resolved
Hide resolved
...defaults/src/main/java/io/delta/kernel/defaults/internal/expressions/SubstringEvaluator.java
Outdated
Show resolved
Hide resolved
...defaults/src/main/java/io/delta/kernel/defaults/internal/expressions/SubstringEvaluator.java
Outdated
Show resolved
Hide resolved
...defaults/src/main/java/io/delta/kernel/defaults/internal/expressions/SubstringEvaluator.java
Outdated
Show resolved
Hide resolved
...st/scala/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluatorSuite.scala
Show resolved
Hide resolved
...defaults/src/main/java/io/delta/kernel/defaults/internal/expressions/SubstringEvaluator.java
Outdated
Show resolved
Hide resolved
vkorukanti
changed the title
SUBSTRING expression and default impl
vkorukanti
requested changes
Jan 2, 2025
...defaults/src/main/java/io/delta/kernel/defaults/internal/expressions/SubstringEvaluator.java
Outdated
Show resolved
Hide resolved
...defaults/src/main/java/io/delta/kernel/defaults/internal/expressions/SubstringEvaluator.java
Outdated
Show resolved
Hide resolved
...defaults/src/main/java/io/delta/kernel/defaults/internal/expressions/SubstringEvaluator.java
Outdated
Show resolved
Hide resolved
...defaults/src/main/java/io/delta/kernel/defaults/internal/expressions/SubstringEvaluator.java
Outdated
Show resolved
Hide resolved
...defaults/src/main/java/io/delta/kernel/defaults/internal/expressions/SubstringEvaluator.java
Outdated
Show resolved
Hide resolved
...st/scala/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluatorSuite.scala
Outdated
Show resolved
Hide resolved
vkorukanti
approved these changes
Jan 6, 2025
...ults/src/main/java/io/delta/kernel/defaults/internal/expressions/DefaultExpressionUtils.java
Outdated
Show resolved
Hide resolved
...ults/src/main/java/io/delta/kernel/defaults/internal/expressions/DefaultExpressionUtils.java
Outdated
Show resolved
Hide resolved
...ults/src/main/java/io/delta/kernel/defaults/internal/expressions/DefaultExpressionUtils.java
Outdated
Show resolved
Hide resolved
...st/scala/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluatorSuite.scala
Outdated
Show resolved
Hide resolved
| input, | ||
| substring(new Column(col_name), 1, Option(1)), | ||
| // scalastyle:off nonascii | ||
| Seq[String](null, "o", "t", "t", "f", null, null, "s", "e", "😉", "e")) |
There was a problem hiding this comment.
the last character (e) for (ë) result same in other systems?
Also for the emoji (does it have surrogate pairs)?
There was a problem hiding this comment.
Also for the emoji (does it have surrogate pairs)?
iiuc yes given
System.out.println("😉".length()) -> 2
the last character (e) for (ë) result same in other systems?
Verified the following using mysql
select substring("ë",1,1) ->
| substring("ë",1,1) |
|---|
| e |
vkorukanti
approved these changes
Jan 7, 2025
huan233usc
added a commit
to huan233usc/delta
that referenced
this pull request
Jan 17, 2025
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md 2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP] Your PR title ...'. 3. Be sure to keep the PR description updated to reflect all changes. 4. Please write your PR title to summarize what this PR proposes. 5. If possible, provide a concise example to reproduce the issue for a faster review. 6. If applicable, include the corresponding issue number in the PR title and link it in the body. --> #### Which Delta project/connector is this regarding? <!-- Please add the component selected below to the beginning of the pull request title For example: [Spark] Title of my pull request --> - [ ] Spark - [ ] Standalone - [ ] Flink - [x] Kernel - [ ] Other (fill in here) ## Description <!-- - Describe what this PR changes. - Describe why we need the change. If this PR resolves an issue be sure to include "Resolves #XXX" to correctly link and close the issue upon merge. --> Implements substring expression. This is 2/n for addressing delta-io#2539 (i.e. data skipping of startwith depends on substring expression, see[1] for spark's code pointer), the first part is implemented in delta-io#4007. [1]https://github.com/delta-io/delta/blob/master/spark/src/main/scala/org/apache/spark/sql/delta/stats/DataSkippingReader.scala#L557-L561 ## How was this patch tested? <!-- If tests were added, say they were added here. Please make sure to test the changes thoroughly including negative and positive cases if possible. If the changes were tested in any way other than unit tests, please clarify how you tested step by step (ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future). If the changes were not tested, please explain why. --> Added e2e test cases, the expected result are generated using spark, e.g. WITH t(x) AS (SELECT null union all select "one" union all select "two" union all select "three" union all select "four" union all select null union all select null union all select "seven" union all select "eight") select substring(x,-100,98) from t substring(x,-100,98) null o t thr fo null null sev eig ## Does this PR introduce _any_ user-facing changes? <!-- If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If possible, please also clarify if this is a user-facing change compared to the released Delta Lake versions or within the unreleased branches such as master. If no, write 'No'. --> No --------- Co-authored-by: Xin Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Implements substring expression. This is 2/n for addressing #2539 (i.e. data skipping of startwith depends on substring expression, see[1] for spark's code pointer), the first part is implemented in #4007.
[1]https://github.com/delta-io/delta/blob/master/spark/src/main/scala/org/apache/spark/sql/delta/stats/DataSkippingReader.scala#L557-L561
How was this patch tested?
Added e2e test cases, the expected result are generated using spark, e.g.
WITH t(x) AS
(SELECT null union all select "one" union all select "two" union all select "three" union all select "four" union all select null union all select null union all select "seven" union all select "eight")
select substring(x,-100,98) from t
substring(x,-100,98)
null
o
t
thr
fo
null
null
sev
eig
Does this PR introduce any user-facing changes?
No