[Kernel] [CC Refactor #1] Add TableIdentifier API
#3795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottsand-db
commented
Oct 22, 2024
| @@ -269,6 +290,22 @@ public long getVersionAtOrAfterTimestamp(Engine engine, long millisSinceEpochUTC | |||
| } | |||
| } | |||
|
|
|||
| //////////////////// | |||
| // Protected APIs // | |||
There was a problem hiding this comment.
protected APIs should be below public APIs
scottsand-db
commented
Oct 22, 2024
| this.tablePath = tablePath; | ||
| final Path dataPath = new Path(tablePath); | ||
| final Path logPath = new Path(dataPath, "_delta_log"); |
There was a problem hiding this comment.
we were duplicating this Path creation in the getDataPath and getLogPath methods. might as well just save them as instance variables.
scottsand-db
commented
Oct 22, 2024
| @@ -169,8 +199,7 @@ public CloseableIterator<ColumnarBatch> getChanges( | |||
| for (int rowId = 0; rowId < protocolVector.getSize(); rowId++) { | |||
| if (!protocolVector.isNullAt(rowId)) { | |||
| Protocol protocol = Protocol.fromColumnVector(protocolVector, rowId); | |||
| TableFeatures.validateReadSupportedTable( | |||
| protocol, getDataPath().toString(), Optional.empty()); | |||
| TableFeatures.validateReadSupportedTable(protocol, tablePath, Optional.empty()); | |||
There was a problem hiding this comment.
getDataPath().toString is the same as tablePath
scottsand-db
commented
Oct 23, 2024
kernel/kernel-api/src/main/java/io/delta/kernel/TableIdentifier.java
Outdated
Show resolved
Hide resolved
ebyhr
reviewed
Oct 24, 2024
kernel/kernel-api/src/main/java/io/delta/kernel/TableIdentifier.java
Outdated
Show resolved
Hide resolved
vkorukanti
reviewed
Oct 25, 2024
| * @return the table identifier, or {@link Optional#empty()} if none is set. | ||
| * @since 3.3.0 | ||
| */ | ||
| Optional<TableIdentifier> getTableIdentifier(Engine engine); |
There was a problem hiding this comment.
I thought we wanted to remove the Engine as arg to APIs going forward.
There was a problem hiding this comment.
Yup! We do. We should do that in one final pass. Until then, I'm going to stick with the current convention.
kernel/kernel-api/src/main/java/io/delta/kernel/TableIdentifier.java
Outdated
Show resolved
Hide resolved
ebyhr
reviewed
Oct 27, 2024
kernel/kernel-api/src/main/java/io/delta/kernel/TableIdentifier.java
Outdated
Show resolved
Hide resolved
scottsand-db
commented
Oct 29, 2024
sumeet-db
approved these changes
Oct 29, 2024
prakharjain09
approved these changes
Oct 29, 2024
allisonport-db
approved these changes
Oct 31, 2024
scottsand-db
force-pushed
the
delta_kernel_cc_1
branch
from
f373f74
to
188f144
Compare
scottsand-db
force-pushed
the
delta_kernel_cc_1
branch
from
188f144
to
768e637
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
TableIdentifierclass, that kernel will pass on to Commit Coordinator ClientTable::forPathWithTableId(engine, path, tableId)interfaceOptionalin theTable, and this PR does not propagate that value into SnapshotManager, Snapshot, etc. Future PRs can take care of that.How was this patch tested?
TableIdentifier UTs
Does this PR introduce any user-facing changes?
Yes. See the above.