[Spark] Nicer error when failing to read table due to type change not support… #3728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanl-db
force-pushed
the
type-widening-nicer-error
branch
from
325cd2d
to
9d250cc
Compare
xupefei
reviewed
Sep 27, 2024
| // Delta 3.2/3.3 doesn't support changing type from int->long, we manually commit that type | ||
| // change to simulate what Delta 4.0 could do. | ||
| deltaLog.withNewTransaction { txn => | ||
| txn.commit( |
There was a problem hiding this comment.
Commit a new protocol with TypeWideningPreviewTableFeature supported?
There was a problem hiding this comment.
Type widening is enabled automatically by default on all tables created in this test suite:
This adds the preview table feature to the table
Is that what you were pointing out?
…ed by the preview of type widening
vkorukanti
force-pushed
the
type-widening-nicer-error
branch
from
25c0f7b
to
3015095
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Delta 3.2/3.3 only supports a limited subset of type changes that will become available with Delta 4.0 / Spark 4.0.
This changes improves the error returned when reading a table with an unsupported type change to tell user to upgrade to Delta 4.0 in case the type change will be supported in that version.
How was this patch tested?
Added tests to cover the error path.
Does this PR introduce any user-facing changes?
Updates error thrown on unsupported type change when reading a table.