[Spark] Better error messages when file name collides #3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunchao
force-pushed
the
better-assertion-message
branch
from
bd34a06
to
50b7efa
Compare
sunchao
force-pushed
the
better-assertion-message
branch
from
80dd446
to
a10edf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Currently in
generateCandidateFileMapwe'd dump all files innameToAddFileMapwhen duplicates are found. This is very tedious to debug since the list could be very long and it is very hard to identity which are the duplicates.This changes it to only output those duplicates with the corresponding keys.
How was this patch tested?
Existing tests.
Does this PR introduce any user-facing changes?
No