-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra] [Spark] Reduce delta-spark CI test runtime by 33 mins (1h46m to 1h13m) #3712
Open
scottsand-db
wants to merge
7
commits into
delta-io:master
Choose a base branch
from
scottsand-db:improved_delta_spark_test_assignment
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Infra] [Spark] Reduce delta-spark CI test runtime by 33 mins (1h46m to 1h13m) #3712
scottsand-db
wants to merge
7
commits into
delta-io:master
from
scottsand-db:improved_delta_spark_test_assignment
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottsand-db
force-pushed
the
improved_delta_spark_test_assignment
branch
from
September 23, 2024 18:57
c01294c
to
f3833ac
Compare
scottsand-db
force-pushed
the
improved_delta_spark_test_assignment
branch
from
September 23, 2024 19:14
f3833ac
to
5a3e12c
Compare
scottsand-db
commented
Sep 23, 2024
scottsand-db
commented
Sep 23, 2024
scottsand-db
changed the title
[Infra] [Spark] Improve delta-spark test assignment / distribution among CI Shards / Groups
[Infra] [Spark] Improve delta-spark test assignment / distribution among CI Shards / Groups [Attempt 1]
Sep 24, 2024
scottsand-db
commented
Sep 24, 2024
scottsand-db
commented
Sep 24, 2024
scottsand-db
commented
Sep 24, 2024
scottsand-db
changed the title
[Infra] [Spark] Improve delta-spark test assignment / distribution among CI Shards / Groups [Attempt 1]
[Infra] [Spark] Reduce delta-spark CI test runtime by 25 mins
Sep 24, 2024
scottsand-db
changed the title
[Infra] [Spark] Reduce delta-spark CI test runtime by 25 mins
[Infra] [Spark] Reduce delta-spark CI test runtime by 25 mins (1h46m to 1h21m)
Sep 24, 2024
scottsand-db
changed the title
[Infra] [Spark] Reduce delta-spark CI test runtime by 25 mins (1h46m to 1h21m)
[Infra] [Spark] Reduce delta-spark CI test runtime by 33 mins (1h46m to 1h13m)
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This PR reduces delta-spark CI test runtime by 33 mins. Previously the max shard duration was 1h 46 mins, and now it is 1h 13 mins.
This PR does so by the following
TestParallelization
to do smarter test suite assignment. The logic is as follows:Note that purely adding another shard and using a better hash function does NOT yield any better results. That was attempted here: #3715.
How was this patch tested?
GitHub Ci tests.
https://github.com/delta-io/delta/actions/runs/11004181545?pr=3712
Does this PR introduce any user-facing changes?
No.