[Storage] Remove file path cache tech debt from S3SingleDriverLogStore #3685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottsand-db
force-pushed
the
s3_logstore_remove_written_path_cache
branch
from
94b239a
to
5e12b9f
Compare
scottsand-db
changed the title
scottsand-db
changed the title
vkorukanti
approved these changes
Sep 18, 2024
scottsand-db
force-pushed
the
s3_logstore_remove_written_path_cache
branch
from
4065a9e
to
d06282e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
S3 has been strongly consistent (for
GET,PUT,LIST) for years (announcement), yet theS3SingleDriverLogStorehas had code that assumes S3 is read-after-write inconsistent.This PR removes such redundant code.
How was this patch tested?
Existing unit tests.
Does this PR introduce any user-facing changes?
No.