[Kernel] Cleanup the FileNames.java utility methods #3588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlm365
force-pushed
the
cleanup-file-util
branch
from
69f9c90
to
50d9235
Compare
tlm365
force-pushed
the
cleanup-file-util
branch
from
6ffae97
to
aabfc4f
Compare
Signed-off-by: Tai Le Manh <[email protected]>
Signed-off-by: Tai Le Manh <[email protected]>
Signed-off-by: Tai Le Manh <[email protected]>
tlm365
force-pushed
the
cleanup-file-util
branch
from
aabfc4f
to
ebed6e8
Compare
tlm365
changed the title
|
It seems that the failed CI is unrelated to this PR. @vkorukanti @nastra Could you guys take a look please |
nastra
reviewed
Aug 22, 2024
| @@ -100,4 +101,8 @@ object Checkstyle { | |||
| } | |||
| } | |||
|
|
|||
| // Enforce java code style | |||
| lazy val javafmtCheckSettings = Seq( | |||
There was a problem hiding this comment.
this isn't really related to checkstyle itself, so I'm a bit undecided whether this should be moved here
nastra
reviewed
Aug 22, 2024
| @@ -156,11 +156,6 @@ lazy val commonSettings = Seq( | |||
| unidocSourceFilePatterns := Nil, | |||
| ) | |||
|
|
|||
| // enforce java code style | |||
There was a problem hiding this comment.
is there a particular reason why this needs to be moved?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Resolves #3586.
Cleanup the
FileNamesutility methods.*minor: Migrate
javafmtCheckSettingstoproject/Checkstyle, I thought it was a bit small to open another PR, so I combined it with this Cleanup PR. (btw, thanks to @nastra,javafmtAllis awesome).How was this patch tested?
CI workflow.
Does this PR introduce any user-facing changes?
No.