Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spark] Pin the pip version to 24.0 to get around the version format requirement #3484

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

vkorukanti
Copy link
Collaborator

(cherry-pick #3302)

... enforced by the pip from 24.1

Recent delta-spark CI
jobs
are failing with the following error.

ERROR: Invalid requirement: 'delta-spark==3.3.0-SNAPSHOT': Expected end or semicolon (after version specifier)
    delta-spark==3.3.0-SNAPSHOT
               ~~~~~~~^

Earlier
runs had the following warning

DEPRECATION: delta-spark 3.3.0-SNAPSHOT has a non-standard version number. pip 23.3 will enforce this behaviour change. A possible replacement is to upgrade to a newer version of delta-spark or contact the author to suggest that they release a version with a conforming version number. Discussion can be found at https://github.com/pypa/pip/issues/12063

Pinning the pip version to 23.2.1 to let the jobs pass. We need to find a long-term solution on the version of the PyPI generated to avoid this issue but it is a bit complicated as the delta-spark PyPI also depends on the delta jars with the same version as the PyPI package name.

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

How was this patch tested?

Does this PR introduce any user-facing changes?

…mat requirement (delta-io#3302)

... enforced by the `pip` from `24.1`

Recent `delta-spark` [CI
jobs](https://github.com/delta-io/delta/actions/runs/9628486756/job/26556785657)
are failing with the following error.
```
ERROR: Invalid requirement: 'delta-spark==3.3.0-SNAPSHOT': Expected end or semicolon (after version specifier)
    delta-spark==3.3.0-SNAPSHOT
               ~~~~~~~^
```

Earlier
[runs](https://github.com/delta-io/delta/actions/runs/9526169441/job/26261227425)
had the following warning
```
DEPRECATION: delta-spark 3.3.0-SNAPSHOT has a non-standard version number. pip 23.3 will enforce this behaviour change. A possible replacement is to upgrade to a newer version of delta-spark or contact the author to suggest that they release a version with a conforming version number. Discussion can be found at pypa/pip#12063
```

Pinning the `pip` version to `23.2.1` to let the jobs pass. We need to
find a long-term solution on the version of the PyPI generated to avoid
this issue but it is a bit complicated as the `delta-spark` PyPI also
depends on the delta jars with the same version as the PyPI package
name.
@vkorukanti vkorukanti merged commit 400caf4 into delta-io:branch-3.0 Aug 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants