-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust the S3DynamoDBLogStore to be compatible with ScyllaDB's Alternator. #2410
base: master
Are you sure you want to change the base?
Adjust the S3DynamoDBLogStore to be compatible with ScyllaDB's Alternator. #2410
Conversation
…ator. Adding `spark.io.delta.storage.S3DynamoDBLogStore.ddb.endpoint` configuration (not mandatory).
… ScyllaDB for S3DynamoDBLogStore log store.
… ScyllaDB for S3DynamoDBLogStore log store.
@scottsand-db , @mrk-its - there were numerous discussions on Delta OSS Slack around adding S3 concurrent write support, that would not rely on AWS DynamoDB, but rather an open-source database (including the one I started some months ago - https://delta-users.slack.com/archives/CJ70UCSHM/p1689589392090319). Who would be the right person to review and approve this PR? |
Hi @rbushri - this looks great! Seems like we should rename Seems like we could have some generic abstract parent class, and keep the child class name |
@scottsand-db, thank you for your review. I've implemented the changes you suggested and updated the PR description. If these changes are acceptable to you, I'll proceed to update the documentation. |
@scottsand-db, would you kindly consider reviewing the changes I made? |
@rbushri - yes! sorry, thinks have been very busy focusing on the delta 3.1 release! will take a look |
Thanks @scottsand-db! I truly appreciate your review. |
storage-s3-dynamodb/src/main/java/io/delta/storage/BaseS3DynamoDBLogStore.java
Outdated
Show resolved
Hide resolved
storage-s3-dynamodb/src/main/java/io/delta/storage/BaseS3DynamoDBLogStore.java
Show resolved
Hide resolved
@scottsand-db, I've addressed your comments and updated the documentation. could you review it, please? |
@rbushri I'm impatiently awaiting this feature getting merged 🙏 . Does this include using delta with write locks via Scylla when interfacing with python (via delta-rs)? UPDATE: I managed to patch in my custom endpoint into delta-rs and will contribute this to their repo once the code is more clean. |
@scottsand-db, Would you kindly review the changes I've made? |
its been 4 months passed, any updates on this PR? |
Hey all, thanks for your patience. Will try to find time to review this in the coming week. Thanks! |
@scottsand-db Any progress with this ? Would be much appreciated if you could push this forward |
Which Delta project/connector is this regarding?
Description
This PR aims to create a cloud-agnostic solution for the Delta Lake on S3 Multiple Writers issue using ScyllaDB's Alternator. It offers an open-source solution for S3 and S3-compatible storage lacking the
putIfAbsent
functionality.The implementation includes the addition of an abstraction layer for DynamoDB LogStore (io.delta.storage.BaseDynamoDBLogStore) and introduces two implementations:
The configuration details for ScyllaDB are as follows:
Resolves #2411, #1336, #1441
How was this patch tested?
Unit test - SUCCEEDED
Manual test :
Does this PR introduce any user-facing changes?
No