[Spark] Introduce V2 Checkpoint actions, table feature #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakharjain09
force-pushed
the
cm-actions
branch
from
6d6699a
to
37458a9
Compare
prakharjain09
force-pushed
the
cm-actions
branch
from
37458a9
to
b420f6d
Compare
ryan-johnson-databricks
approved these changes
Aug 17, 2023
|
|
||
| /** Converts a `name` String into a [[Policy]] */ | ||
| def fromName(name: String): Policy = ALL.find(_.name == name).getOrElse { | ||
| throw new IllegalStateException(s"Invalid policy $name") |
There was a problem hiding this comment.
Any particular reason it's IllegalState instead of IllegalArgument?
There was a problem hiding this comment.
IllegalArgument suits better - fixing this.
Comment on lines
+631
to
+632
| fromString = str => CheckpointPolicy.fromName(str), | ||
| validationFunction = (v => CheckpointPolicy.ALL.exists(_.name == v.name)), |
There was a problem hiding this comment.
Do we care that it's case sensitive?
(I'm fine either way, just checking that it's intentional)
There was a problem hiding this comment.
I think most of the other table properties don't handle lower/upper case - following the same pattern.
Comment on lines
349
to
351
| DeltaUtils.isTesting || SparkSession.getActiveSession.map { spark => | ||
| spark.conf.get(DeltaSQLConf.EXPOSE_CHECKPOINT_V2_TABLE_FEATURE_FOR_TESTING) | ||
| }.getOrElse(false) |
There was a problem hiding this comment.
nit: simpler?
Suggested change
| DeltaUtils.isTesting || SparkSession.getActiveSession.map { spark => | |
| spark.conf.get(DeltaSQLConf.EXPOSE_CHECKPOINT_V2_TABLE_FEATURE_FOR_TESTING) | |
| }.getOrElse(false) | |
| DeltaUtils.isTesting || SparkSession.getActiveSession.exists { spark => | |
| spark.conf.get(DeltaSQLConf.EXPOSE_CHECKPOINT_V2_TABLE_FEATURE_FOR_TESTING) | |
| } |
There was a problem hiding this comment.
could also do
Suggested change
| DeltaUtils.isTesting || SparkSession.getActiveSession.map { spark => | |
| spark.conf.get(DeltaSQLConf.EXPOSE_CHECKPOINT_V2_TABLE_FEATURE_FOR_TESTING) | |
| }.getOrElse(false) | |
| SparkSession.getActiveSession.map { spark => | |
| spark.conf.get(DeltaSQLConf.EXPOSE_CHECKPOINT_V2_TABLE_FEATURE_FOR_TESTING) | |
| }.getOrElse(DeltaUtils.isTesting) |
Comment on lines
1227
to
1229
| val tagMapWithSchema = sidecarFileSchemaOpt | ||
| .map(schema => Map(Tags.SIDECAR_FILE_SCHEMA.name -> schema.json)) | ||
| .getOrElse(Map.empty) |
There was a problem hiding this comment.
Suggested change
| val tagMapWithSchema = sidecarFileSchemaOpt | |
| .map(schema => Map(Tags.SIDECAR_FILE_SCHEMA.name -> schema.json)) | |
| .getOrElse(Map.empty) | |
| val tagMapWithSchema = sidecarFileSchemaOpt.map(Tags.SIDECAR_FILE_SCHEMA.name -> _.json) |
(Map.++ below accepts anything that resembles TraversibleOnce)
| .checkValues(Set("json", "parquet")) | ||
| .createOptional | ||
|
|
||
| val EXPOSE_CHECKPOINT_V2_TABLE_FEATURE_FOR_TESTING = |
There was a problem hiding this comment.
This is temporary, to be removed once the feature is ready for general use?
|
LGTM. |
vkorukanti
pushed a commit
to vkorukanti/delta
that referenced
this pull request
Sep 6, 2023
This PR introduces actions and placeholder TableFeature for V2 Checkpoints. Closes [delta-io#1983](delta-io#1983) GitOrigin-RevId: fd41917ea6b21701defe422ef643fd0ff59e125f
|
Merged as 22ade20 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Introduces actions for V2 Checkpoints - checkpointMetadata, sidecarFiles. Also introduces TableFeature for V2 Checkpoints.
Currently the feature is named with suffix
-under-development. It will be removed in a later PR when all other pieces are merged.Part of #1793 .
How was this patch tested?
UTs
Does this PR introduce any user-facing changes?
No