Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kernel] Cleanup the FileNames.java utility methods #3588

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tlm365
Copy link
Contributor

@tlm365 tlm365 commented Aug 21, 2024

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

Resolves #3586.

Cleanup the FileNames utility methods.
*minor: Migrate javafmtCheckSettings to project/Checkstyle, I thought it was a bit small to open another PR, so I combined it with this Cleanup PR. (btw, thanks to @nastra, javafmtAll is awesome).

How was this patch tested?

CI workflow.

Does this PR introduce any user-facing changes?

No.

@tlm365 tlm365 changed the title [WIP] [Kernel] Cleanup the FileNames.java utility methods [Kernel] Cleanup the FileNames.java utility methods Aug 22, 2024
@tlm365
Copy link
Contributor Author

tlm365 commented Aug 22, 2024

It seems that the failed CI is unrelated to this PR.

@vkorukanti @nastra Could you guys take a look please

@tlm365 tlm365 marked this pull request as ready for review August 22, 2024 14:39
@@ -100,4 +101,8 @@ object Checkstyle {
}
}

// Enforce java code style
lazy val javafmtCheckSettings = Seq(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't really related to checkstyle itself, so I'm a bit undecided whether this should be moved here

@@ -156,11 +156,6 @@ lazy val commonSettings = Seq(
unidocSourceFilePatterns := Nil,
)

// enforce java code style
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a particular reason why this needs to be moved?

@vkorukanti vkorukanti self-assigned this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Kernel] Cleanup the FileNames.java utility methods
3 participants