Reduce memory usage in parquet format code path #737
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two optimizations:
split_blocks=False
. I believesplit_blocks=True
was initially introduced in case it might help with memory usage during the arrow to pandas conversion. However, it should be set to false for three reasons:split_blocks=True
may cause pandas consolidations when other operations are done on the dataframe later on. In some of my test tables, this has indeed introduced unnecessary consolidations and actually increased memory usage.Because change 1 may result in worse performance, this change is gated behind the param
convert_in_batches
, which is false by default.Also updated the docstrings of
load_as_pandas
andload_table_changes_as_pandas
.Tested with unit tests.