-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part 2: propogate transform in visit_scan_files #612
base: main
Are you sure you want to change the base?
Part 2: propogate transform in visit_scan_files #612
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #612 +/- ##
==========================================
+ Coverage 83.43% 83.45% +0.02%
==========================================
Files 75 75
Lines 16922 17115 +193
Branches 16922 17115 +193
==========================================
+ Hits 14119 14284 +165
- Misses 2146 2164 +18
- Partials 657 667 +10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double checking -- this PR makes almost no functional changes (other than printing the transforms)? It's mostly wiring to prepare for the next PR?
ffi/src/scan.rs
Outdated
} | ||
|
||
// #[no_mangle] | ||
// /// allow probing into a CStringMap. If the specified key is in the map, kernel will call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// /// allow probing into a CStringMap. If the specified key is in the map, kernel will call | |
// /// allow probing into a CTransformMap. If the specified key is in the map, kernel will call |
(tho probably this whole chunk of code should just be moved to the later FFI PR?)
ff5d5fe
to
e88db7e
Compare
Yep, that's right. Just keeping things in logical chunks as much as possible. Hopefully that made the reviews easier |
Stacked PR: Only review these commits
What changes are proposed in this pull request?
Propagate the computed transforms from #607 through calls to
visit_scan_files
.Just a draft to allow seeing where this will go. Probably needs tests (although all existing tests pass).
How was this change tested?