Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 2: propogate transform in visit_scan_files #612

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

nicklan
Copy link
Collaborator

@nicklan nicklan commented Dec 20, 2024

Stacked PR: Only review these commits

What changes are proposed in this pull request?

Propagate the computed transforms from #607 through calls to visit_scan_files.

Just a draft to allow seeing where this will go. Probably needs tests (although all existing tests pass).

How was this change tested?

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 82.87037% with 37 lines in your changes missing coverage. Please review.

Project coverage is 83.45%. Comparing base (ba37b62) to head (da29cc7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kernel/src/scan/log_replay.rs 85.71% 7 Missing and 11 partials ⚠️
ffi/src/scan.rs 0.00% 16 Missing ⚠️
kernel/src/scan/mod.rs 95.31% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #612      +/-   ##
==========================================
+ Coverage   83.43%   83.45%   +0.02%     
==========================================
  Files          75       75              
  Lines       16922    17115     +193     
  Branches    16922    17115     +193     
==========================================
+ Hits        14119    14284     +165     
- Misses       2146     2164      +18     
- Partials      657      667      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double checking -- this PR makes almost no functional changes (other than printing the transforms)? It's mostly wiring to prepare for the next PR?

ffi/src/scan.rs Outdated
}

// #[no_mangle]
// /// allow probing into a CStringMap. If the specified key is in the map, kernel will call
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// /// allow probing into a CStringMap. If the specified key is in the map, kernel will call
// /// allow probing into a CTransformMap. If the specified key is in the map, kernel will call

(tho probably this whole chunk of code should just be moved to the later FFI PR?)

@nicklan nicklan force-pushed the part-2-propogate-transform-in-visit-scan-files branch from ff5d5fe to e88db7e Compare January 10, 2025 01:23
@nicklan
Copy link
Collaborator Author

nicklan commented Jan 10, 2025

Just double checking -- this PR makes almost no functional changes (other than printing the transforms)? It's mostly wiring to prepare for the next PR?

Yep, that's right. Just keeping things in logical chunks as much as possible. Hopefully that made the reviews easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Change that will require a version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants