Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add check for schema read compatibility #554

Merged
merged 17 commits into from
Jan 23, 2025
Merged

feat: Add check for schema read compatibility #554

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
868f446
Initial schema compat
OussamaSaoudi-db Nov 28, 2024
277361e
Add schema compatibility tests
OussamaSaoudi-db Nov 29, 2024
0d8bdc6
Add error-based schema compatibility check
OussamaSaoudi-db Jan 2, 2025
39e3755
Remove old schema compat
OussamaSaoudi-db Jan 3, 2025
e50a8dd
change naming, remove redundant test
OussamaSaoudi-db Jan 7, 2025
cc4f067
Improve comments, add check that field names aren't case-insensitive …
OussamaSaoudi-db Jan 7, 2025
112ef81
Change ordering, remove unnecessary comment
OussamaSaoudi-db Jan 7, 2025
17148fd
Add comments to can_read_as methods
OussamaSaoudi-db Jan 7, 2025
d80b8e0
Move to struct/impl based nullability check
OussamaSaoudi-db Jan 8, 2025
8510615
Make StructType::can_read_as developer-visibility pub
OussamaSaoudi-db Jan 8, 2025
b8cd7fb
Switch macro order
OussamaSaoudi-db Jan 9, 2025
5d2bd60
remove imports to make it clear the types that are impl
OussamaSaoudi-db Jan 10, 2025
e7768b4
ignore doctest for private member
OussamaSaoudi-db Jan 10, 2025
d0f3ebc
Address PR comments
OussamaSaoudi Jan 21, 2025
8cd9e09
address pr comments
OussamaSaoudi Jan 22, 2025
9506c1b
Merge branch 'main' into schema-compat
OussamaSaoudi Jan 23, 2025
b53b68f
fix small bits
OussamaSaoudi Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions kernel/src/schema.rs → kernel/src/schema/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ pub(crate) use crate::expressions::{column_name, ColumnName};
use crate::utils::require;
use crate::{DeltaResult, Error};

pub(crate) mod schema_compare;
OussamaSaoudi marked this conversation as resolved.
Show resolved Hide resolved

pub type Schema = StructType;
pub type SchemaRef = Arc<StructType>;

Expand Down
Loading
Loading