This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27
[QA] Some fixes part 1 #26
Open
allisonport-db
wants to merge
8
commits into
delta-io:main
Choose a base branch
from
allisonport-db:docs-fix-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonport-db
commented
Feb 13, 2023
•
edited
Loading
edited
- Removes extra pages that are not linked/used
- Misc fixes for the optimizations, table properties and delta resources pages
- Anchor tags for sections with parenthesis or dashes in a heading don't work (page doesn't load to the right spot) --> added tags right above the sub-heading
- Fixes a bunch of links
- Code formatting
- Other misc items
✅ Deploy Preview for delta-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@@ -273,7 +273,7 @@ The preceding example continuously updates a table that contains the aggregate n | |||
|
|||
For applications with more lenient latency requirements, you can save computing resources with one-time triggers. Use these to update summary aggregation tables on a given schedule, processing only new data that has arrived since the last update. | |||
|
|||
## Idempotent table writes in `foreachBatch` | |||
## Idempotent table writes in foreachBatch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, <code>...</code>
works and looks better in Header2s (##
).
Anyways, it seems we both did delta-streaming
. https://github.com/delta-io/delta-docs/pull/39/files#diff-87d0d2367f1ffef73543eec8952b76ba882ec93954c372f7eab0ab85d3832f6fR284
Want to drop these changes from this PR? And we will use mine instead?
scottsand-db
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with 1 small change (remove changes to delta-streaming.mdx)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.