-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: integrate contract query #8
Conversation
@CarlWiles could you resolve the conflicts in your branch? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am getting a response and there is data there. I think there are some issues with the decimals (maybe on converting the exchange rate?):
protocol,date,block_number,user_address,market,supply_token,borrow_token
RhoMarkets,1719322991,6913571,0xf874afa0b950270dc702740904d103822307f028,0xad3d07d431b85b525d81372802504fa18dbd554c,0.046775996935733383,0.23387994345100485
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, nice work @CarlWiles
Title:
Checklist before requesting a review
index.ts file
Contains function
getUserTVLByBlock function takes input with this schema
getUserTVLByBlock function returns output in this schema
contains function
has this code
Your code is handling Pagination to make sure all data for a given block is returned
Output data