Add spot price after swap to schema #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe make it optional for all but v3s? |
melotik
reviewed
Sep 9, 2024
schemas/dex/schema.json
Outdated
| @@ -246,6 +246,10 @@ | |||
| "description": "The amount of the output token, decimal normalized.", | |||
| "type": "number" | |||
| }, | |||
| "spot_price_after_swap": { | |||
| "description": "The spot price in the pool after the swap is complete.", | |||
There was a problem hiding this comment.
Should this be in USD? Or is there another denomination across all dexs?
There was a problem hiding this comment.
Let's keep it not optional, if a protocol doesn't have this available, they can mark it null or 0
There was a problem hiding this comment.
It's a ratio between the two tokens. v3 DEXs show the tick after the swap, which tells us the price ratio.
There was a problem hiding this comment.
Can we add something about this to the description?
melotik
reviewed
Sep 9, 2024
schemas/dex/schema.json
Outdated
| @@ -246,6 +246,10 @@ | |||
| "description": "The amount of the output token, decimal normalized.", | |||
| "type": "number" | |||
| }, | |||
| "spot_price_after_swap": { | |||
| "description": "The spot price in the pool after the swap is complete.", | |||
There was a problem hiding this comment.
Let's keep it not optional, if a protocol doesn't have this available, they can mark it null or 0
melotik
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to add spot price after swap to the DEX swap schema. I want this so I can tell which liquidity is in range at any given time.
I don't know if this is feasible for all DEX types. Maybe we should have a separate table for v3 swaps that includes the tick after the swap (which I believe is standard in Uniswap v3 DEXs).