Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interport adapter #48

Merged
merged 4 commits into from
May 6, 2024

Conversation

bogdanuch
Copy link

No description provided.

@0xroll
Copy link
Contributor

0xroll commented Apr 16, 2024

hi @bogdanuch thanks for the PR.

iTokens have transfer events that we should also be tracking of.

user A deposits -> transfer iToken to user B

@bogdanuch
Copy link
Author

hi @bogdanuch thanks for the PR.

iTokens have transfer events that we should also be tracking of.

user A deposits -> transfer iToken to user B

Do you want me to detect in possession of iToken at the end? Because the person who added the liquidity is the one who made deposit.
I'm also not completely sure that Transfer is only used for deposit/withdrawal and transfer of tokens between users(I can check if it's what required).

@0xroll
Copy link
Contributor

0xroll commented Apr 16, 2024

hi @bogdanuch thanks for the PR.
iTokens have transfer events that we should also be tracking of.
user A deposits -> transfer iToken to user B

Do you want me to detect in possession of iToken at the end? Because the person who added the liquidity is the one who made deposit. I'm also not completely sure that Transfer is only used for deposit/withdrawal and transfer of tokens between users(I can check if it's what required).

so ideally we are looking at who owns the liquidity(TVL).
so yes, we should have the transfers event factored in as well to get the correct owner

@bogdanuch
Copy link
Author

hi @bogdanuch thanks for the PR.
iTokens have transfer events that we should also be tracking of.
user A deposits -> transfer iToken to user B

Do you want me to detect in possession of iToken at the end? Because the person who added the liquidity is the one who made deposit. I'm also not completely sure that Transfer is only used for deposit/withdrawal and transfer of tokens between users(I can check if it's what required).

so ideally we are looking at who owns the liquidity(TVL). so yes, we should have the transfers event factored in as well to get the correct owner

Is it better right now?

@0xroll
Copy link
Contributor

0xroll commented May 6, 2024

thanks, please remember to submit new PRs when new token pools are integrated in your protocol.

lets merge this @nitish-91

@nitish-91 nitish-91 merged commit ca6bc38 into delta-hq:main May 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants