Add dyson finance adapter #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dyson finance adapter
0xroll
previously approved these changes
Apr 16, 2024
|
@ytwang00 hi can you fix to pass the test check? also when users deposit , are they given a receipt token? if yes we should also be tracking these in adapter |
Modify folder stucture
|
@0xroll |
0xroll
reviewed
Apr 22, 2024
Use real number
|
@0xroll |
Fix pagination issue
|
@0xroll DYSON_POSITIONS_QUERY => fetching all data with pagination |
0xroll
approved these changes
Jun 6, 2024
adapters/dysonfinance/src/index.ts
Outdated
Comment on lines
43
to
56
| const DYSON_POSITIONS_QUERY = ` | ||
| query DysonPositionsQuery($blockNumber: Int!) { | ||
| noteEntities(first: 1000, skip: 0, where: {isWithdrawed: false}, block: {number: $blockNumber}, orderBy: timestamp, orderDirection: desc) { | ||
| timestamp | ||
| user | ||
| pair | ||
| depositType | ||
| depositAmt | ||
| token0Amt | ||
| token1Amt | ||
| isWithdrawed | ||
| } | ||
| } | ||
| `; |
There was a problem hiding this comment.
you need to add in pagination so that we do not miss any active positions
There was a problem hiding this comment.
May 5th and two days ago?
I must have missed that...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.