Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mendi adapter #38

Merged
merged 2 commits into from
Apr 22, 2024
Merged

feat: add mendi adapter #38

merged 2 commits into from
Apr 22, 2024

Conversation

gathonwar
Copy link
Contributor

fix: zero values and math rounding

fix: zero values and math rounding
@0xroll
Copy link
Contributor

0xroll commented Apr 16, 2024

hi @gathonwar

some questions on this PR :

  1. is this returning the net balance? net asset balance = supplied - borrowed
  2. this doesnt seem to factor in interests gained/accrued from supplying and borrowing

kindly provide the subgraph repo link

@nitish-91
Copy link
Contributor

@gathonwar can you please implement the function as mentioned in the readme.
https://github.com/delta-hq/l2-lxp-liquidity-reward/tree/main?tab=readme-ov-file#code-changes-expected

Also please reply to @0xroll 's questions

@gathonwar
Copy link
Contributor Author

hi @0xroll,

  1. yes, these are net balances
  2. interest are accumulated in supply side because we are using tokens and exchange rate to calculate supplied amount. they were not included in borrow side, the second commit is getting borrow balance at block number (interests are included).

@RamonReis RamonReis merged commit 7899953 into delta-hq:main Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants