-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MYX Finance : DEX : tvl by user #135
Conversation
@0xroll Already updated as requested✅ |
adapters/myx/src/index.ts
Outdated
|
||
|
||
const getData = async () => { | ||
const snapshotBlocks = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocks should be received as input parameter.
@marvin6en You have marked everything on the checklist but i dont see the code taking
|
@nitish-91 It has been fixed, please check again |
snapshotsMap.forEach((userPositionSnapshotMap => { | ||
userPositionSnapshotMap.forEach((positionSnapshot) => { | ||
userPositionSnapshotsAtBlockData.push({ | ||
user_address: positionSnapshot.recipient, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this return multiple block numbers for 1 block input?
Same question for timestamp as well
@marvin6en
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at line 55-58,Already filtered based on blocknumber
Title:
Checklist before requesting a review
index.ts file
Contains function
getUserTVLByBlock function takes input with this schema
getUserTVLByBlock function returns output in this schema
contains function
has this code
Output data