Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add histogram command and plug it to spa & metaslab commands #207

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

sdimitro
Copy link
Contributor

@sdimitro sdimitro commented Apr 8, 2020

Commit:

Want command to print ZFS Histograms
Histogram option for spa, vdev, and metaslab commands

This code is not optimal but I decided to open the PR so we have something for 6.0.2.0 (see https://jira.delphix.com/browse/DLPX-67353). I opened #206 for the leftover work (spa,vdev,metaslab refactoring).

Note:
I thought about making this a pretty printer but unfortunately we can't specify an generic uint64_t array as an input type, in a way that drgn understands (maybe we can add our own layer a weaker type equality where comparing arrays of the same type yields true regardless of whether they have the same length or not). I could create two pretty printers for these histograms though a 64 and a 32 bucket version, If people feel strongly let me know and I can change this.

Other Ideas:
Would people be interested in additional behavior where if a metaslab is loaded we print the rt_histogram of the ms_allocatable instead and we calculate the precise median from the range tree?

@sdimitro
Copy link
Contributor Author

sdimitro commented Apr 8, 2020

cc @grwilson

sdb/commands/zfs/histograms.py Show resolved Hide resolved
sdb/commands/zfs/histograms.py Outdated Show resolved Hide resolved
sdb/commands/zfs/histograms.py Outdated Show resolved Hide resolved
sdb/commands/zfs/histograms.py Outdated Show resolved Hide resolved
sdb/commands/zfs/histograms.py Outdated Show resolved Hide resolved
sdb/commands/zfs/histograms.py Outdated Show resolved Hide resolved
sdb/commands/zfs/histograms.py Outdated Show resolved Hide resolved
@sdimitro sdimitro force-pushed the zfs_histograms branch 2 times, most recently from 6463381 to 08c1242 Compare April 9, 2020 05:12
sdb/commands/zfs/histograms.py Outdated Show resolved Hide resolved
sdb/commands/zfs/metaslab.py Outdated Show resolved Hide resolved
sdb/commands/zfs/metaslab.py Outdated Show resolved Hide resolved
@sdimitro sdimitro force-pushed the zfs_histograms branch 2 times, most recently from 6e51c79 to 876e55e Compare April 9, 2020 21:15
Histogram option for spa, vdev, and metaslab commands
@sdimitro sdimitro merged commit 47debdd into delphix:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants