-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add histogram command and plug it to spa & metaslab commands #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @grwilson |
ahrens
reviewed
Apr 8, 2020
sdimitro
force-pushed
the
zfs_histograms
branch
2 times, most recently
from
April 9, 2020 05:12
6463381
to
08c1242
Compare
ahrens
approved these changes
Apr 9, 2020
sdimitro
force-pushed
the
zfs_histograms
branch
2 times, most recently
from
April 9, 2020 21:15
6e51c79
to
876e55e
Compare
prakashsurya
reviewed
Apr 9, 2020
prakashsurya
reviewed
Apr 9, 2020
prakashsurya
approved these changes
Apr 9, 2020
Histogram option for spa, vdev, and metaslab commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit:
This code is not optimal but I decided to open the PR so we have something for 6.0.2.0 (see https://jira.delphix.com/browse/DLPX-67353). I opened #206 for the leftover work (spa,vdev,metaslab refactoring).
Note:
I thought about making this a pretty printer but unfortunately we can't specify an generic
uint64_t
array as an input type, in a way that drgn understands (maybe we can add our own layer a weaker type equality where comparing arrays of the same type yields true regardless of whether they have the same length or not). I could create two pretty printers for these histograms though a 64 and a 32 bucket version, If people feel strongly let me know and I can change this.Other Ideas:
Would people be interested in additional behavior where if a metaslab is loaded we print the rt_histogram of the ms_allocatable instead and we calculate the precise median from the range tree?