Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLPX-92534 linux-pkg changes for LTS upgrade to 24.04 #325

Draft
wants to merge 3 commits into
base: os-upgrade
Choose a base branch
from

Conversation

palash-gandhi
Copy link
Contributor

@palash-gandhi palash-gandhi commented Oct 3, 2024

Problem

This PR contains changes required for the Ubuntu LTS upgrade to 24.04 and as such targets the os-upgrade branch. It mainly removes a few internal sources in favor of upstream packages and also enables building the remaining packages on 24.04.

Solution

The following are the changes, along with explanations for each:

  1. adoptopenjdk: Prior to this PR, the JDK was sourced and downloaded from our internal artifactory. There is no reason why we cannot install this via apt.
  2. bpftrace, bcc, drgn, fio, gdb-python, libkdumpfile and mold: All of these packages also can be sourced directly from their respective upstream sources (dependent changes WIP)
  3. llvm-12 is not available on 24.04. As such update connstat and zfs's build dependency to depend on llvm-14 instead.
  4. zfs also requires additional packages:
    • dh-dkms
    • libpam0g: The bootstrap image that the current + future OS upgrade projects will initially use is based on a vanilla Ubuntu image, and not a Delphix-based buildserver. Hence, the PAM headers need to be installed as a build dependency of ZFS
    • libtirpc-dev

Testing Done

WIP

@palash-gandhi palash-gandhi force-pushed the dlpx/pr/palash-gandhi/545afa70-4102-4fa9-bd91-b5d72eb35fd5 branch 3 times, most recently from 8afa695 to e678599 Compare October 3, 2024 19:43
@palash-gandhi palash-gandhi changed the title Stop consuming fio and gdb-python from internal forks in favor of upstream packages for LTS upgrade Stop consuming bpftrace, bcc, fio, gdb-python and mold from internal forks in favor of upstream packages for LTS upgrade Oct 3, 2024
@palash-gandhi palash-gandhi force-pushed the dlpx/pr/palash-gandhi/545afa70-4102-4fa9-bd91-b5d72eb35fd5 branch 2 times, most recently from 9974ef3 to 499fcc5 Compare October 16, 2024 21:19
@palash-gandhi palash-gandhi force-pushed the dlpx/pr/palash-gandhi/545afa70-4102-4fa9-bd91-b5d72eb35fd5 branch 2 times, most recently from 751fb09 to 8fa2fda Compare October 17, 2024 04:47
@palash-gandhi palash-gandhi changed the title Stop consuming bpftrace, bcc, fio, gdb-python and mold from internal forks in favor of upstream packages for LTS upgrade Stop consuming adoptopenjdk, bpftrace, bcc, fio, gdb-python and mold from internal forks in favor of upstream packages for LTS upgrade Oct 17, 2024
@palash-gandhi palash-gandhi force-pushed the dlpx/pr/palash-gandhi/545afa70-4102-4fa9-bd91-b5d72eb35fd5 branch from 8fa2fda to 22b3e97 Compare October 17, 2024 19:15
@palash-gandhi palash-gandhi changed the title Stop consuming adoptopenjdk, bpftrace, bcc, fio, gdb-python and mold from internal forks in favor of upstream packages for LTS upgrade Stop relying on internal sources in favor of upstream packages for LTS upgrade Oct 24, 2024
@palash-gandhi palash-gandhi force-pushed the dlpx/pr/palash-gandhi/545afa70-4102-4fa9-bd91-b5d72eb35fd5 branch 11 times, most recently from 254e4ee to dde565b Compare October 25, 2024 23:33
@palash-gandhi palash-gandhi changed the title Stop relying on internal sources in favor of upstream packages for LTS upgrade DLPX-92534 linux-pkg changes for LTS upgrade to 24.04 Oct 25, 2024
@prakashsurya
Copy link
Contributor

Prior to this PR, the JDK was sourced and downloaded from our internal artifactory. There is no reason why we cannot install this via apt.

can you clarify why it's OK to remove the adoptopenjdk package? why did we need it to begin with?

@palash-gandhi
Copy link
Contributor Author

Prior to this PR, the JDK was sourced and downloaded from our internal artifactory. There is no reason why we cannot install this via apt.

can you clarify why it's OK to remove the adoptopenjdk package? why did we need it to begin with?

From https://perforce.slack.com/archives/C07HB5Y7K8S/p1729097131001349, it sounds like it was an old process that we stuck to and there's no reason to maintain a copy of the package in artifactory.

@prakashsurya
Copy link
Contributor

Thanks, OK.. I'd defer to Seb, so if he's OK with it, then seems reasonable to me.. perhaps when we started down that path, there wasn't a JDK 8 available from ubuntu..

@palash-gandhi palash-gandhi force-pushed the dlpx/pr/palash-gandhi/545afa70-4102-4fa9-bd91-b5d72eb35fd5 branch 10 times, most recently from 39ba085 to dd1b9fc Compare December 6, 2024 08:21
@palash-gandhi palash-gandhi force-pushed the dlpx/pr/palash-gandhi/545afa70-4102-4fa9-bd91-b5d72eb35fd5 branch from dd1b9fc to cea9bac Compare December 6, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants