Warnings and memory leaks

[reicrof]

Hey !
FIrst of all, thanks for your code, it has been working well for the few tests I made.
I don't know if it still relevant to you but I had 2 minor issues when using your b2separator. First, there were warnings on some type conversions so I explicitly casted them to allow for a warning free compilation. Second, I've noticed there were some memory leaks here and there, so I added the delete.
Thats all !
Cheers
Charles.

[delorenj]

awesome! thanks!

It's neat to see someone using making use of (and fixing) my code =)

On Thu, May 21, 2015 at 10:34 AM, reicrof [email protected] wrote:

Hey !
FIrst of all, thanks for your code, it has been working well for the few
tests I made.
I don't know if it still relevant to you but I had 2 minor issues when
using your b2separator. First, there were warnings on some type conversions
so I explicitly casted them to allow for a warning free compilation.
Second, I've noticed there were some memory leaks here and there, so I
added the delete.
Thats all !
Cheers

Charles.

You can view, comment on, or merge this pull request online at:

#2
Commit Summary

• Fixed conversion types warning by casting them into their respective
  types.

File Changes

• M b2Separator.cpp
  https://github.com/delorenj/b2Separator-cpp/pull/2/files#diff-0 (16)

Patch Links:

• https://github.com/delorenj/b2Separator-cpp/pull/2.patch
• https://github.com/delorenj/b2Separator-cpp/pull/2.diff

—
Reply to this email directly or view it on GitHub
#2.