Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating test coverage for DSAP and LC attributes #274

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Updating test coverage for DSAP and LC attributes #274

merged 2 commits into from
Jan 17, 2025

Conversation

sapana05
Copy link
Contributor

SUMMARY

Updating test coverage for DSAP and LC attributes

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

@sapana05 sapana05 requested a review from a team as a code owner January 16, 2025 11:06
@terraform-providers-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@sapana05 sapana05 force-pushed the UT-fix branch 2 times, most recently from d9b31a3 to 9f12813 Compare January 16, 2025 11:22
@sapana05
Copy link
Contributor Author

image
image
image
image
image
image
image
image
image
image

@sapana05
Copy link
Contributor Author

run e2e test

1 similar comment
@sapana05
Copy link
Contributor Author

run e2e test

@sapana05
AT coverage Improvement
430a3bd 
adding space after comment line

adding space after comment line

updating testcase for DSAP

updating DSAP UT coverage

updating testcase for LC attributes

updating test for coverage

revert bios config
@sapana05
Copy link
Contributor Author

run e2e test

MangirishK
MangirishK previously approved these changes Jan 17, 2025
View reviewed changes
@sapana05
removed RSA2FA related code
03fb2d2 
removing commented code
@Krunal-Thakkar
Copy link
Collaborator

run e2e test RedfishDirectoryServiceAuthProviderInvalidCase,RedfishLCAttribute,RedfishDirectoryServiceAuthProviderBasic,RedfishDirectoryServiceAuthProviderInvalidSchema_Config,RedfishDirectoryServiceAuthProviderImport

1 similar comment
@Krunal-Thakkar
Copy link
Collaborator

run e2e test RedfishDirectoryServiceAuthProviderInvalidCase,RedfishLCAttribute,RedfishDirectoryServiceAuthProviderBasic,RedfishDirectoryServiceAuthProviderInvalidSchema_Config,RedfishDirectoryServiceAuthProviderImport

@sapana05 sapana05 merged commit 961f814 into main Jan 17, 2025
6 checks passed
@sapana05 sapana05 deleted the UT-fix branch January 17, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bhavneet-Sharma Bhavneet-Sharma Bhavneet-Sharma approved these changes

@Krunal-Thakkar Krunal-Thakkar Krunal-Thakkar approved these changes

@MangirishK MangirishK MangirishK left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sapana05 @terraform-providers-svc @Krunal-Thakkar @MangirishK @Bhavneet-Sharma