Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synciq doc #263

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Synciq doc #263

merged 6 commits into from
Nov 26, 2024

Conversation

Krishnan-Priyanshu
Copy link
Contributor

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • Test Pull Request
RESOURCE OR DATASOURCE NAME
OUTPUT
ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
  • Acceptance tests

gokul-srivathsan
gokul-srivathsan approved these changes Nov 26, 2024
View reviewed changes
Copy link

@gokul-srivathsan gokul-srivathsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Krishnan-Priyanshu
Copy link
Contributor Author

run e2e test ReplicationReportsDataSource

1 similar comment
@shenda1
Copy link
Contributor

shenda1 commented Nov 26, 2024

run e2e test ReplicationReportsDataSource

@Krishnan-Priyanshu Krishnan-Priyanshu merged commit 92635dd into main Nov 26, 2024
7 checks passed
@Krishnan-Priyanshu Krishnan-Priyanshu deleted the synciq-doc branch November 26, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnikaAgiwal2711 AnikaAgiwal2711 AnikaAgiwal2711 left review comments

@gokul-srivathsan gokul-srivathsan gokul-srivathsan approved these changes

@shenda1 shenda1 shenda1 approved these changes

@forrestxia forrestxia Awaiting requested review from forrestxia forrestxia is a code owner

@baoy1 baoy1 Awaiting requested review from baoy1 baoy1 is a code owner

@taohe1012 taohe1012 Awaiting requested review from taohe1012 taohe1012 is a code owner

@P-Cao P-Cao Awaiting requested review from P-Cao P-Cao is a code owner

@tanh17 tanh17 Awaiting requested review from tanh17 tanh17 is a code owner

@doriac11 doriac11 Awaiting requested review from doriac11 doriac11 is a code owner

@nikitajoshi1 nikitajoshi1 Awaiting requested review from nikitajoshi1 nikitajoshi1 is a code owner

@shekhar-j shekhar-j Awaiting requested review from shekhar-j shekhar-j is a code owner

@RayLiu7 RayLiu7 Awaiting requested review from RayLiu7 RayLiu7 is a code owner

@vangork vangork Awaiting requested review from vangork vangork is a code owner

@sapana05 sapana05 Awaiting requested review from sapana05 sapana05 is a code owner

@MangirishK MangirishK Awaiting requested review from MangirishK MangirishK is a code owner

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell Sakshi-dell is a code owner

@Krunal-Thakkar Krunal-Thakkar Awaiting requested review from Krunal-Thakkar Krunal-Thakkar is a code owner

@rounak-adhikary rounak-adhikary Awaiting requested review from rounak-adhikary rounak-adhikary is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Krishnan-Priyanshu @shenda1 @AnikaAgiwal2711 @gokul-srivathsan