Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Storagepool tier datasource #259

Merged
merged 20 commits into from
Dec 11, 2024
Merged

Adding Storagepool tier datasource #259

merged 20 commits into from
Dec 11, 2024

Conversation

ABHISHEK-SINHA10
Copy link
Contributor

@ABHISHEK-SINHA10 ABHISHEK-SINHA10 commented Nov 20, 2024 •
edited
Loading

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Feature Pull Request
RESOURCE OR DATASOURCE NAME
OUTPUT

Image

ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
  • Acceptance tests

@ABHISHEK-SINHA10 ABHISHEK-SINHA10 self-assigned this Nov 20, 2024
@terraform-providers-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@shenda1
Copy link
Contributor

shenda1 commented Nov 20, 2024

@ABHISHEK-SINHA10

  • If any changes are needed in go client, OpenAPI specs needs to be updated
  • Attach coverage report

@ABHISHEK-SINHA10
Copy link
Contributor Author

UT
(coverage)
Acceptance testing
Mock server calls

@shenda1
Copy link
Contributor

shenda1 commented Nov 29, 2024

run e2e test StoragepoolTierDatasource

@shenda1
Copy link
Contributor

shenda1 commented Dec 10, 2024

run e2e test StoragepoolTierDatasource

rounak-adhikary
rounak-adhikary reviewed Dec 10, 2024
View reviewed changes
powerscale/provider/storagepool_tier_datasource.go Outdated
ElementType: types.Int32Type,
},
"name": schema.StringAttribute{
Description: "Manage protection settings.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can you please double-check and confirm that these descriptions are correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ABHISHEK-SINHA10 can you pls confirm the descriptions for all the other fields too?
For example, I see that the description of children is Manage I/O optimization settings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rounak-adhikary Thanks for pointing out, I have checked all the description and now it's updated, please check once again

@shenda1
Copy link
Contributor

shenda1 commented Dec 10, 2024

run e2e test StoragepoolTierDatasource

@Sakshi-dell
Copy link
Contributor

run e2e test StoragepoolTierDatasource

@ABHISHEK-SINHA10
Copy link
Contributor Author

Updated description and generated doc, no impact on testcase or coverage

@ABHISHEK-SINHA10
Copy link
Contributor Author

ABHISHEK-SINHA10 commented Dec 11, 2024 •
edited
Loading

image
image

Testcase working fine with UT and mock server test(No changes needed on mock server from my side, it's working fine after Trisha's PR merge on mock server)

@shenda1
Copy link
Contributor

shenda1 commented Dec 11, 2024

run e2e test StoragepoolTierDatasource

@ABHISHEK-SINHA10 ABHISHEK-SINHA10 merged commit d00a7cd into main Dec 11, 2024
7 checks passed
@ABHISHEK-SINHA10 ABHISHEK-SINHA10 deleted the usr/ABHISHEK_SINHA10/storage_pool_tiering_data_source branch December 11, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Krunal-Thakkar Krunal-Thakkar Krunal-Thakkar approved these changes

@shenda1 shenda1 shenda1 approved these changes

@forrestxia forrestxia Awaiting requested review from forrestxia forrestxia is a code owner

@baoy1 baoy1 Awaiting requested review from baoy1 baoy1 is a code owner

@taohe1012 taohe1012 Awaiting requested review from taohe1012 taohe1012 is a code owner

@P-Cao P-Cao Awaiting requested review from P-Cao P-Cao is a code owner

@tanh17 tanh17 Awaiting requested review from tanh17 tanh17 is a code owner

@doriac11 doriac11 Awaiting requested review from doriac11 doriac11 is a code owner

@nikitajoshi1 nikitajoshi1 Awaiting requested review from nikitajoshi1 nikitajoshi1 is a code owner

@shekhar-j shekhar-j Awaiting requested review from shekhar-j shekhar-j is a code owner

@RayLiu7 RayLiu7 Awaiting requested review from RayLiu7 RayLiu7 is a code owner

@vangork vangork Awaiting requested review from vangork vangork is a code owner

@sapana05 sapana05 Awaiting requested review from sapana05 sapana05 is a code owner

@MangirishK MangirishK Awaiting requested review from MangirishK MangirishK is a code owner

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell Sakshi-dell is a code owner

@rounak-adhikary rounak-adhikary Awaiting requested review from rounak-adhikary rounak-adhikary is a code owner

Assignees

@ABHISHEK-SINHA10 ABHISHEK-SINHA10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ABHISHEK-SINHA10 @terraform-providers-svc @shenda1 @Sakshi-dell @rounak-adhikary @Krunal-Thakkar