Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix security issue #126

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Fix security issue #126

merged 1 commit into from
Feb 29, 2024

Conversation

NavisJ
Copy link
Contributor

@NavisJ NavisJ commented Feb 26, 2024 •
edited
Loading

Description

Upgrade dependency version per the black duck scan

Pipeline build: https://osj-sio-03-prd.cec.lab.emc.com/job/Terraform-Pipelines/job/tf-manual/1041/

image

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • [] Unit tests
  • Acceptance tests

@NavisJ NavisJ force-pushed the fix-security-issue branch from 0e2a46e to a3bdc0d Compare February 26, 2024 14:52
@NavisJ
Copy link
Contributor Author

NavisJ commented Feb 26, 2024

run e2e test

@NavisJ
Copy link
Contributor Author

NavisJ commented Feb 27, 2024

run e2e test

@NavisJ NavisJ force-pushed the fix-security-issue branch from a3bdc0d to 34c5def Compare February 27, 2024 10:51
@NavisJ NavisJ force-pushed the fix-security-issue branch from 34c5def to 4f05cce Compare February 27, 2024 14:32
@NavisJ
Copy link
Contributor Author

NavisJ commented Feb 27, 2024

run e2e test

@NavisJ NavisJ merged commit ed516c0 into main Feb 29, 2024
7 checks passed
@NavisJ NavisJ deleted the fix-security-issue branch February 29, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taohe1012 taohe1012 taohe1012 approved these changes

@shenda1 shenda1 Awaiting requested review from shenda1 shenda1 is a code owner

@forrestxia forrestxia Awaiting requested review from forrestxia forrestxia is a code owner

@baoy1 baoy1 Awaiting requested review from baoy1 baoy1 is a code owner

@P-Cao P-Cao Awaiting requested review from P-Cao P-Cao is a code owner

@tanh17 tanh17 Awaiting requested review from tanh17 tanh17 is a code owner

@doriac11 doriac11 Awaiting requested review from doriac11 doriac11 is a code owner

@nikitajoshi1 nikitajoshi1 Awaiting requested review from nikitajoshi1 nikitajoshi1 is a code owner

@shekhar-j shekhar-j Awaiting requested review from shekhar-j shekhar-j is a code owner

@RayLiu7 RayLiu7 Awaiting requested review from RayLiu7 RayLiu7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NavisJ @taohe1012