Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACL Settings Resource Implementation #123

Merged
merged 1 commit into from
Feb 8, 2024
Merged

ACL Settings Resource Implementation #123

merged 1 commit into from
Feb 8, 2024

Conversation

RayLiu7
Copy link
Contributor

@RayLiu7 RayLiu7 commented Feb 6, 2024

Description

ACL Settings Resource Implementation

ISSUE TYPE

  • Feature Pull Request
RESOURCE NAME

ACL Settings

OUTPUT

image
image

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
  • Acceptance tests

@RayLiu7 RayLiu7 force-pushed the aclsettings-resource branch from de0f041 to db5e204 Compare February 6, 2024 03:07
@RayLiu7
Copy link
Contributor Author

RayLiu7 commented Feb 6, 2024

run e2e test

@RayLiu7 RayLiu7 merged commit 3b55fb5 into main Feb 8, 2024
7 checks passed
@RayLiu7 RayLiu7 deleted the aclsettings-resource branch February 8, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants