updating overwrite flag for filesystem (#261)

* updating overwrite flag for filesystem Signed-off-by: shenda1 <[email protected]> * fixing s3 bucket datasource test Signed-off-by: shenda1 <[email protected]> * adding TestAcc prefix Signed-off-by: shenda1 <[email protected]> --------- Signed-off-by: shenda1 <[email protected]> Co-authored-by: rounak-adhikary <[email protected]>
dell · Nov 20, 2024 · 90a6020 · 90a6020
1 parent 42bf570
commit 90a6020
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 13 deletions.
diff --git a/powerscale/provider/file_system_resource_test.go b/powerscale/provider/file_system_resource_test.go
@@ -34,7 +34,7 @@ var createMockerLocal *mockey.Mocker
 var setACLMockerLocal *mockey.Mocker
 var metadataMocker *mockey.Mocker
 
-func TestFileSystemResourceWithUIDChange(t *testing.T) {
+func TestAccFileSystemResourceWithUIDChange(t *testing.T) {
 	var fileSystemResourceName = "powerscale_filesystem.file_system_test"
 	resource.Test(t, resource.TestCase{
 		PreCheck:                 func() { testAccPreCheck(t) },
@@ -74,7 +74,7 @@ func TestFileSystemResourceWithUIDChange(t *testing.T) {
 	})
 }
 
-func TestFileSystemResource(t *testing.T) {
+func TestAccFileSystemResource(t *testing.T) {
 	var fileSystemResourceName = "powerscale_filesystem.file_system_test"
 	resource.Test(t, resource.TestCase{
 		PreCheck:                 func() { testAccPreCheck(t) },
@@ -155,7 +155,7 @@ func TestFileSystemResource(t *testing.T) {
 	})
 }
 
-func TestFileSystemResourceUpdate(t *testing.T) {
+func TestAccFileSystemResourceUpdate(t *testing.T) {
 	var fileSystemResourceName = "powerscale_filesystem.file_system_test"
 	resource.Test(t, resource.TestCase{
 		PreCheck:                 func() { testAccPreCheck(t) },
@@ -195,7 +195,7 @@ func TestFileSystemResourceUpdate(t *testing.T) {
 		},
 	})
 }
-func TestFileSystemResourceUpdateMetadataError(t *testing.T) {
+func TestAccFileSystemResourceUpdateMetadataError(t *testing.T) {
 
 	resource.Test(t, resource.TestCase{
 		PreCheck:                 func() { testAccPreCheck(t) },
@@ -246,7 +246,7 @@ func TestFileSystemResourceUpdateMetadataError(t *testing.T) {
 	})
 }
 
-func TestFileSystemResourceUpdateGetAclError(t *testing.T) {
+func TestAccFileSystemResourceUpdateGetAclError(t *testing.T) {
 
 	resource.Test(t, resource.TestCase{
 		PreCheck:                 func() { testAccPreCheck(t) },
@@ -315,7 +315,7 @@ func TestFileSystemResourceUpdateGetAclError(t *testing.T) {
 	})
 }
 
-func TestFileSystemResourceUpdateUserErr(t *testing.T) {
+func TestAccFileSystemResourceUpdateUserErr(t *testing.T) {
 	resource.Test(t, resource.TestCase{
 		PreCheck:                 func() { testAccPreCheck(t) },
 		ProtoV6ProviderFactories: testAccProtoV6ProviderFactories,
@@ -361,7 +361,7 @@ func TestFileSystemResourceUpdateUserErr(t *testing.T) {
 		},
 	})
 }
-func TestFileSystemResourceUpdateFail(t *testing.T) {
+func TestAccFileSystemResourceUpdateFail(t *testing.T) {
 
 	resource.Test(t, resource.TestCase{
 		PreCheck:                 func() { testAccPreCheck(t) },
@@ -556,7 +556,7 @@ resource "powerscale_filesystem" "file_system_test" {
 	name = "tfaccDirTfUpd"
   
 	recursive = true
-	overwrite = false
+	overwrite = true
 	group = {
 	  id   = "GID:0"
 	  name = "wheel"
@@ -579,7 +579,7 @@ resource "powerscale_filesystem" "file_system_test" {
 	name = "tfaccDirTfUpd"
   
 	recursive = true
-	overwrite = false
+	overwrite = true
 	group = {
 	  id   = "GID:0"
 	  name = "wheel"
@@ -602,7 +602,7 @@ resource "powerscale_filesystem" "file_system_test" {
 	name = "tfaccDirTfUpdErr"
   
 	recursive = true
-	overwrite = false
+	overwrite = true
 	group = {
 	  id   = "GID:0"
 	  name = "wheel"
@@ -626,7 +626,7 @@ resource "powerscale_filesystem" "file_system_test" {
 	name = "tfaccDirTf"
   
 	recursive = true
-	overwrite = false
+	overwrite = true
 	group = {
 	  id   = "GID:0"
 	  name = "wheel"
@@ -657,7 +657,7 @@ resource "powerscale_filesystem" "file_system_test" {
 	name = "tfaccDirTf"
   
 	recursive = true
-	overwrite = false
+	overwrite = true
 	group = {
 	  id   = "GID:0"
 	}
@@ -689,7 +689,7 @@ resource "powerscale_filesystem" "file_system_test" {
 
 	name = "tfaccDirTf"
 	recursive = true
-	overwrite = false
+	overwrite = true
 	group = {
 		name = "tfaccUserGroupDatasource",
 	}

diff --git a/powerscale/provider/s3_bucket_datasource_test.go b/powerscale/provider/s3_bucket_datasource_test.go
@@ -148,6 +148,7 @@ resource "powerscale_s3_bucket" "bucket_resource_test" {
 	name = "%s"
 	path = "/ifs/%s"
 	create_path = true
+	zone  = "System"
 	acl = [{
 		grantee = {
 			name = "Everyone"