Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting issue #185

Merged
merged 5 commits into from
Jan 3, 2024
Merged

Fix linting issue #185

merged 5 commits into from
Jan 3, 2024

Conversation

xuluna
Copy link
Contributor

@xuluna xuluna commented Jan 2, 2024

Description

  • Fix format and linting issues
  • Added skip dirs for go mod libraries (third party libraries)
  • Change ssh.InsecureIgnoreHostKey() callback to a hostkey implementation that accepts empty string and emits a warning message of hostkey

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#926

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit test
  • e2e integration test

@xuluna xuluna merged commit d496870 into main Jan 3, 2024
7 checks passed
@xuluna xuluna deleted the luna/lint branch January 3, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants