Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go Lib Update #170

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Go Lib Update #170

merged 2 commits into from
Jul 11, 2024

Conversation

HarishH-DELL
Copy link
Contributor

Description

Go lib updates

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1221

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No

@csmbot
Copy link
Collaborator

csmbot commented Jul 11, 2024

Can one of the admins verify this patch?

Copy link

@shefali-malhotra shefali-malhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update all dell lib versions .

@HarishH-DELL
Copy link
Contributor Author

Please update all dell lib versions .

addressed

@shefali-malhotra shefali-malhotra merged commit 6f5d307 into main Jul 11, 2024
7 checks passed
@shefali-malhotra shefali-malhotra deleted the go_lib_update branch July 11, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants