[charts/cosi] add COSI driver helm chart #267

mdutka-dell · 2023-08-24T11:15:15Z

Is this a new chart?

Yes

What this PR does / why we need it:

Adding COSI driver to the helm-charts repo.

Which issue(s) is this PR associated with:

KRV-16397

Special notes for your reviewer:

Adding COSI driver / Kube Linter GitHub Action.

Checklist:

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

Chart Version bumped
Variables are documented in the chart README.md
Title of the PR starts with the chart name (e.g. [charts_dir/mychartname]) if applicable

tdawe · 2023-08-28T11:59:10Z

.github/workflows/cosi-helm.yaml

+  TOKEN: ${{ secrets.GH_DELL_ACCESS }}
+
+jobs:
+  kube-linter:


There is an existing linter used for all charts located here: https://github.com/dell/helm-charts/blob/main/.github/workflows/helm-validations.yml#L29C6-L29C6

This file may no longer be required or that existing helm-validations.yml file could be updated if this new kube-linter-action is more up to date than what we are using in our existing workflow.

As you can see here: https://github.com/dell/helm-charts/actions/runs/5999804015/job/16270649466?pr=267, after adding scanning to the whole repo many issues in other charts appeared.

I think that in this PR the cosi chart should be scanned, but other teams should correct their charts. The additional tasks have to be planned.

@tdawe To add my 5 cents, I think there should be (at least) 2 configurations for KubeLinter, as the rules applicable to things like COSI Driver or CS Modules, might not be applicable to CSI Drivers, as CSI Drivers are interacting with K8s Node's filesystem.

…into add_cosi_driver

charts/cosi/templates/_helpers.tpl

* add cosi driver helm chart * add cosi specific linters * remove go mod from cosi linters * fix typos * add cosi-ct-config.yaml * change workflow name * change log levels in cosi chart * update actions * change name from cosi-driver to cosi * add kubelinter for all charts * revert kubelinter * change log levels in chart's template --------- Co-authored-by: mtrajfacki-dell <[email protected]>

* Update CODEOWNERS (#238) * add powerflex helm chart changes for v1.7.1. (#245) * add powerflex helm chart changes for v1.7.1. * add helm chart changes for v1.7.1 release. (#246) * Skip existing releases (#272) * updated helm-validations file (#243) * Powerscale v2.8.0 release (#242) * Powerscale v2.8.0 release * Added suppoert container-storage-modules * Added suppoert container-storage-modules * recommiting branch due to checks not working * dummy commit to trigger the checks * StorageCapacityTracking feature changes (#236) * Update _helpers.tpl Added changes related to StorageCapacityTracking * Update controller.yaml Added changes related to StorageCapacityTracking * Update csidriver.yaml Added changes related to StorageCapacityTracking * Update values.yaml Added changes related to StorageCapacityTracking * Update _helpers.tpl Storage Capacity Tracking K8s 1.24. * Update values.yaml Changed the version to v1.24 * Update csidriver.yaml Set the default value to false * Update controller.yaml Default value of the StorageCapacityTracking should be true * Update csidriver.yaml Default value should be true * Update controller.yaml Updated the controller file * Update csidriver.yaml Updated csidriver.yaml file * Update controller.yaml Done changes related to SCT * csm-replication: Removed init container usage (#244) * CSIUnity v2.8.0 release (#248) * Updated v2.8.0 unity driver version * addressed review comments on values.yaml file update * Added the Volumelimits for Powermax (#240) Co-authored-by: Yamunadevi N Shanmugam <[email protected]> * PowerFlex v2.8.0 release (#250) * PowerFlex SDC updated (#251) * Adding k8 28 support for powermax (#253) * Adding K8s1.28 support for PowerFlex (#254) * K8s 1.28 support unity (#255) * support k8s v1.28 * support k8s v1.28 * minor typo fixed (#258) * PowerScale k8s-1.28 support (#260) * powerstore v2.8.0 & k8s 1.28 support (#262) * Adding volume limits support for CSIPowerstore * Adding volume limits support for CSIPowerstore * Adding maxPowerstoreVolumesPerNode in values.yaml inside container-storage-modules * Removed duplicate entry for X_CSI_DRIVER_NAME in node.yaml for CSI Powerstore (#273) * update auth to 1.8 (#271) * update auth to 1.8 Signed-off-by: arnchiequ-dell <[email protected]> * Updating podmon to 1.7 Signed-off-by: arnchiequ-dell <[email protected]> * Update Observability values file for Authorization sidecar image version --------- Signed-off-by: arnchiequ-dell <[email protected]> Co-authored-by: Alik Saring <[email protected]> * Update Authorization images version (#277) * Updated replication controller/replicator/migrator/rescanner SC image versions for CSM v1.8.0 (#278) * Updated csi-metadata-retriever version to 1.5.0 for CSI Powerstore (#280) * Update Observability image versions for CSM 1.8. (#281) * Adding CSI Powerstore driver’s effective pod security profile for supporting ephemeral volumes as part of Openshift 4.13 support (#261) Co-authored-by: Surya Gupta <[email protected]> * removed externalAccess from powerflex manifests. (#283) * [charts/cosi] add COSI driver helm chart (#267) * add cosi driver helm chart * add cosi specific linters * remove go mod from cosi linters * fix typos * add cosi-ct-config.yaml * change workflow name * change log levels in cosi chart * update actions * change name from cosi-driver to cosi * add kubelinter for all charts * revert kubelinter * change log levels in chart's template --------- Co-authored-by: mtrajfacki-dell <[email protected]> * Revert "Adding CSI Powerstore driver’s effective pod security profile for supporting ephemeral volumes as part of Openshift 4.13 support (#261)" (#284) This reverts commit c1dd93b. * [charts/container-storage-modules]: Uncomment Resiliency arguments (#287) * uncomment resiliency args * fix spacing * correct cosi log level setting (#288) * [charts/container-storage-modules]: new keys added for PowerFlex driver (#286) * PowerFlex new keys added * NFS ACL parameter removed (#289) * Adding new fields for powermax (#290) * bumped csi-volumegroup-snapshotter version (#292) * reset the CSM helm chart to main branch (#293) --------- Signed-off-by: arnchiequ-dell <[email protected]> Co-authored-by: Yamunadevi N Shanmugam <[email protected]> Co-authored-by: VamsiSiddu-7 <[email protected]> Co-authored-by: chaganti-rajitha <[email protected]> Co-authored-by: HarishH-DELL <[email protected]> Co-authored-by: tssushma <[email protected]> Co-authored-by: Santhosh Lakshmanan <[email protected]> Co-authored-by: karthikk92 <[email protected]> Co-authored-by: KshitijaKakde <[email protected]> Co-authored-by: boyamurthy <[email protected]> Co-authored-by: panigs7 <[email protected]> Co-authored-by: Rajshree Khare <[email protected]> Co-authored-by: Nitesh-Rewatkar <[email protected]> Co-authored-by: Surya Gupta <[email protected]> Co-authored-by: alankar-verma <[email protected]> Co-authored-by: aqu-dell <[email protected]> Co-authored-by: Alik Saring <[email protected]> Co-authored-by: alikdell <[email protected]> Co-authored-by: Don Khan <[email protected]> Co-authored-by: mdutka-dell <[email protected]> Co-authored-by: mtrajfacki-dell <[email protected]> Co-authored-by: shaynafinocchiaro <[email protected]> Co-authored-by: Rishabh Raj <[email protected]> Co-authored-by: Niranjan N <[email protected]>

* add cosi driver helm chart * add cosi specific linters * remove go mod from cosi linters * fix typos * add cosi-ct-config.yaml * change workflow name * change log levels in cosi chart * update actions * change name from cosi-driver to cosi * add kubelinter for all charts * revert kubelinter * change log levels in chart's template --------- Co-authored-by: mtrajfacki-dell <[email protected]>

* updated helm-validations file (#243) * Powerscale v2.8.0 release (#242) * Powerscale v2.8.0 release * Added suppoert container-storage-modules * Added suppoert container-storage-modules * recommiting branch due to checks not working * dummy commit to trigger the checks * StorageCapacityTracking feature changes (#236) * Update _helpers.tpl Added changes related to StorageCapacityTracking * Update controller.yaml Added changes related to StorageCapacityTracking * Update csidriver.yaml Added changes related to StorageCapacityTracking * Update values.yaml Added changes related to StorageCapacityTracking * Update _helpers.tpl Storage Capacity Tracking K8s 1.24. * Update values.yaml Changed the version to v1.24 * Update csidriver.yaml Set the default value to false * Update controller.yaml Default value of the StorageCapacityTracking should be true * Update csidriver.yaml Default value should be true * Update controller.yaml Updated the controller file * Update csidriver.yaml Updated csidriver.yaml file * Update controller.yaml Done changes related to SCT * csm-replication: Removed init container usage (#244) * CSIUnity v2.8.0 release (#248) * Updated v2.8.0 unity driver version * addressed review comments on values.yaml file update * Added the Volumelimits for Powermax (#240) Co-authored-by: Yamunadevi N Shanmugam <[email protected]> * PowerFlex v2.8.0 release (#250) * PowerFlex SDC updated (#251) * Adding k8 28 support for powermax (#253) * Adding K8s1.28 support for PowerFlex (#254) * K8s 1.28 support unity (#255) * support k8s v1.28 * support k8s v1.28 * minor typo fixed (#258) * PowerScale k8s-1.28 support (#260) * powerstore v2.8.0 & k8s 1.28 support (#262) * Adding volume limits support for CSIPowerstore * Adding volume limits support for CSIPowerstore * Adding maxPowerstoreVolumesPerNode in values.yaml inside container-storage-modules * Removed duplicate entry for X_CSI_DRIVER_NAME in node.yaml for CSI Powerstore (#273) * update auth to 1.8 (#271) * update auth to 1.8 Signed-off-by: arnchiequ-dell <[email protected]> * Updating podmon to 1.7 Signed-off-by: arnchiequ-dell <[email protected]> * Update Observability values file for Authorization sidecar image version --------- Signed-off-by: arnchiequ-dell <[email protected]> Co-authored-by: Alik Saring <[email protected]> * Update Authorization images version (#277) * Updated replication controller/replicator/migrator/rescanner SC image versions for CSM v1.8.0 (#278) * Updated csi-metadata-retriever version to 1.5.0 for CSI Powerstore (#280) * Update Observability image versions for CSM 1.8. (#281) * Adding CSI Powerstore driver’s effective pod security profile for supporting ephemeral volumes as part of Openshift 4.13 support (#261) Co-authored-by: Surya Gupta <[email protected]> * updated chart version (#282) * removed externalAccess from powerflex manifests. (#283) * [charts/cosi] add COSI driver helm chart (#267) * add cosi driver helm chart * add cosi specific linters * remove go mod from cosi linters * fix typos * add cosi-ct-config.yaml * change workflow name * change log levels in cosi chart * update actions * change name from cosi-driver to cosi * add kubelinter for all charts * revert kubelinter * change log levels in chart's template --------- Co-authored-by: mtrajfacki-dell <[email protected]> * Revert "Adding CSI Powerstore driver’s effective pod security profile for supporting ephemeral volumes as part of Openshift 4.13 support (#261)" (#284) This reverts commit c1dd93b. * [charts/container-storage-modules]: Uncomment Resiliency arguments (#287) * uncomment resiliency args * fix spacing * correct cosi log level setting (#288) * [charts/container-storage-modules]: new keys added for PowerFlex driver (#286) * PowerFlex new keys added * NFS ACL parameter removed (#289) * Adding new fields for powermax (#290) * bumped csi-volumegroup-snapshotter version (#292) * reset the CSM helm chart to main branch (#293) * [feature-885]: Add workflow update to release branch (#297) * Update CODEOWNERS (#238) * add powerflex helm chart changes for v1.7.1. (#245) * add powerflex helm chart changes for v1.7.1. * add helm chart changes for v1.7.1 release. (#246) * Skip existing releases (#272) * updated helm-validations file (#243) * Powerscale v2.8.0 release (#242) * Powerscale v2.8.0 release * Added suppoert container-storage-modules * Added suppoert container-storage-modules * recommiting branch due to checks not working * dummy commit to trigger the checks * StorageCapacityTracking feature changes (#236) * Update _helpers.tpl Added changes related to StorageCapacityTracking * Update controller.yaml Added changes related to StorageCapacityTracking * Update csidriver.yaml Added changes related to StorageCapacityTracking * Update values.yaml Added changes related to StorageCapacityTracking * Update _helpers.tpl Storage Capacity Tracking K8s 1.24. * Update values.yaml Changed the version to v1.24 * Update csidriver.yaml Set the default value to false * Update controller.yaml Default value of the StorageCapacityTracking should be true * Update csidriver.yaml Default value should be true * Update controller.yaml Updated the controller file * Update csidriver.yaml Updated csidriver.yaml file * Update controller.yaml Done changes related to SCT * csm-replication: Removed init container usage (#244) * CSIUnity v2.8.0 release (#248) * Updated v2.8.0 unity driver version * addressed review comments on values.yaml file update * Added the Volumelimits for Powermax (#240) Co-authored-by: Yamunadevi N Shanmugam <[email protected]> * PowerFlex v2.8.0 release (#250) * PowerFlex SDC updated (#251) * Adding k8 28 support for powermax (#253) * Adding K8s1.28 support for PowerFlex (#254) * K8s 1.28 support unity (#255) * support k8s v1.28 * support k8s v1.28 * minor typo fixed (#258) * PowerScale k8s-1.28 support (#260) * powerstore v2.8.0 & k8s 1.28 support (#262) * Adding volume limits support for CSIPowerstore * Adding volume limits support for CSIPowerstore * Adding maxPowerstoreVolumesPerNode in values.yaml inside container-storage-modules * Removed duplicate entry for X_CSI_DRIVER_NAME in node.yaml for CSI Powerstore (#273) * update auth to 1.8 (#271) * update auth to 1.8 Signed-off-by: arnchiequ-dell <[email protected]> * Updating podmon to 1.7 Signed-off-by: arnchiequ-dell <[email protected]> * Update Observability values file for Authorization sidecar image version --------- Signed-off-by: arnchiequ-dell <[email protected]> Co-authored-by: Alik Saring <[email protected]> * Update Authorization images version (#277) * Updated replication controller/replicator/migrator/rescanner SC image versions for CSM v1.8.0 (#278) * Updated csi-metadata-retriever version to 1.5.0 for CSI Powerstore (#280) * Update Observability image versions for CSM 1.8. (#281) * Adding CSI Powerstore driver’s effective pod security profile for supporting ephemeral volumes as part of Openshift 4.13 support (#261) Co-authored-by: Surya Gupta <[email protected]> * removed externalAccess from powerflex manifests. (#283) * [charts/cosi] add COSI driver helm chart (#267) * add cosi driver helm chart * add cosi specific linters * remove go mod from cosi linters * fix typos * add cosi-ct-config.yaml * change workflow name * change log levels in cosi chart * update actions * change name from cosi-driver to cosi * add kubelinter for all charts * revert kubelinter * change log levels in chart's template --------- Co-authored-by: mtrajfacki-dell <[email protected]> * Revert "Adding CSI Powerstore driver’s effective pod security profile for supporting ephemeral volumes as part of Openshift 4.13 support (#261)" (#284) This reverts commit c1dd93b. * [charts/container-storage-modules]: Uncomment Resiliency arguments (#287) * uncomment resiliency args * fix spacing * correct cosi log level setting (#288) * [charts/container-storage-modules]: new keys added for PowerFlex driver (#286) * PowerFlex new keys added * NFS ACL parameter removed (#289) * Adding new fields for powermax (#290) * bumped csi-volumegroup-snapshotter version (#292) * reset the CSM helm chart to main branch (#293) --------- Signed-off-by: arnchiequ-dell <[email protected]> Co-authored-by: Yamunadevi N Shanmugam <[email protected]> Co-authored-by: VamsiSiddu-7 <[email protected]> Co-authored-by: chaganti-rajitha <[email protected]> Co-authored-by: HarishH-DELL <[email protected]> Co-authored-by: tssushma <[email protected]> Co-authored-by: Santhosh Lakshmanan <[email protected]> Co-authored-by: karthikk92 <[email protected]> Co-authored-by: KshitijaKakde <[email protected]> Co-authored-by: boyamurthy <[email protected]> Co-authored-by: panigs7 <[email protected]> Co-authored-by: Rajshree Khare <[email protected]> Co-authored-by: Nitesh-Rewatkar <[email protected]> Co-authored-by: Surya Gupta <[email protected]> Co-authored-by: alankar-verma <[email protected]> Co-authored-by: aqu-dell <[email protected]> Co-authored-by: Alik Saring <[email protected]> Co-authored-by: alikdell <[email protected]> Co-authored-by: Don Khan <[email protected]> Co-authored-by: mdutka-dell <[email protected]> Co-authored-by: mtrajfacki-dell <[email protected]> Co-authored-by: shaynafinocchiaro <[email protected]> Co-authored-by: Rishabh Raj <[email protected]> Co-authored-by: Niranjan N <[email protected]> --------- Signed-off-by: arnchiequ-dell <[email protected]> Co-authored-by: chaganti-rajitha <[email protected]> Co-authored-by: HarishH-DELL <[email protected]> Co-authored-by: tssushma <[email protected]> Co-authored-by: Santhosh Lakshmanan <[email protected]> Co-authored-by: karthikk92 <[email protected]> Co-authored-by: Yamunadevi N Shanmugam <[email protected]> Co-authored-by: KshitijaKakde <[email protected]> Co-authored-by: boyamurthy <[email protected]> Co-authored-by: panigs7 <[email protected]> Co-authored-by: Rajshree Khare <[email protected]> Co-authored-by: Nitesh-Rewatkar <[email protected]> Co-authored-by: Surya Gupta <[email protected]> Co-authored-by: alankar-verma <[email protected]> Co-authored-by: aqu-dell <[email protected]> Co-authored-by: Alik Saring <[email protected]> Co-authored-by: alikdell <[email protected]> Co-authored-by: Don Khan <[email protected]> Co-authored-by: Niranjan N <[email protected]> Co-authored-by: VamsiSiddu-7 <[email protected]> Co-authored-by: mdutka-dell <[email protected]> Co-authored-by: mtrajfacki-dell <[email protected]> Co-authored-by: shaynafinocchiaro <[email protected]> Co-authored-by: Rishabh Raj <[email protected]>

add cosi driver helm chart

df51de1

mdutka-dell requested review from gallacher, tdawe, alikdell, atye, hoppea2, chaganti-rajitha, coulof, meggm, niranjan-n1, shaynafinocchiaro, sharmilarama, tssushma, taohe1012, P-Cao, shanmydell, baoy1, YianZong and forrestxia as code owners August 24, 2023 11:15

mdutka-dell marked this pull request as draft August 24, 2023 11:15

mdutka-dell changed the title ~~add COSI driver helm chart~~ [charts/cosi] add COSI driver helm chart Aug 24, 2023

mdutka-dell added 6 commits August 24, 2023 08:45

add cosi specific linters

85886a6

remove go mod from cosi linters

acb8d3d

fix typos

1b1aea4

add cosi-ct-config.yaml

ff20466

change workflow name

08b6b06

change log levels in cosi chart

9b2f24c

mdutka-dell marked this pull request as ready for review August 25, 2023 10:01

update actions

0068140

bogdanNovikovDell previously approved these changes Aug 25, 2023

View reviewed changes

change name from cosi-driver to cosi

1279038

mdutka-dell dismissed bogdanNovikovDell’s stale review via 1279038 August 28, 2023 08:08

Merge branch 'release-v1.8.0' into add_cosi_driver

acd938d

mdutka-dell requested a review from bogdanNovikovDell August 28, 2023 11:22

tdawe reviewed Aug 28, 2023

View reviewed changes

mdutka-dell added 2 commits August 28, 2023 08:24

add kubelinter for all charts

c07128b

Merge branch 'add_cosi_driver' of https://github.com/dell/helm-charts …

3d079b8

…into add_cosi_driver

mdutka-dell requested a review from tdawe August 28, 2023 12:50

revert kubelinter

b665359

shanduur-dell approved these changes Aug 30, 2023

View reviewed changes

shanduur-dell suggested changes Aug 30, 2023

View reviewed changes

charts/cosi/templates/_helpers.tpl Outdated Show resolved Hide resolved

change log levels in chart's template

aeb8fb3

shanduur-dell approved these changes Aug 30, 2023

View reviewed changes

Merge branch 'release-v1.8.0' into add_cosi_driver

c869ef2

mtrajfacki-dell approved these changes Aug 30, 2023

View reviewed changes

Merge branch 'release-v1.8.0' into add_cosi_driver

8357564

shanmydell approved these changes Aug 31, 2023

View reviewed changes

mdutka-dell and others added 2 commits August 31, 2023 14:28

Merge branch 'release-v1.8.0' into add_cosi_driver

3b35296

Merge branch 'release-v1.8.0' into add_cosi_driver

3126f29

mtrajfacki-dell merged commit cb3c1e6 into release-v1.8.0 Aug 31, 2023
8 checks passed

mtrajfacki-dell deleted the add_cosi_driver branch August 31, 2023 14:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[charts/cosi] add COSI driver helm chart #267

[charts/cosi] add COSI driver helm chart #267

mdutka-dell commented Aug 24, 2023 •

edited

Loading

tdawe Aug 28, 2023

mdutka-dell Aug 28, 2023

shanduur-dell Aug 28, 2023 •

edited

Loading

[charts/cosi] add COSI driver helm chart #267

[charts/cosi] add COSI driver helm chart #267

Conversation

mdutka-dell commented Aug 24, 2023 • edited Loading

Is this a new chart?

What this PR does / why we need it:

Which issue(s) is this PR associated with:

Special notes for your reviewer:

Checklist:

tdawe Aug 28, 2023

Choose a reason for hiding this comment

mdutka-dell Aug 28, 2023

Choose a reason for hiding this comment

shanduur-dell Aug 28, 2023 • edited Loading

Choose a reason for hiding this comment

mdutka-dell commented Aug 24, 2023 •

edited

Loading

shanduur-dell Aug 28, 2023 •

edited

Loading