Powerstore volume limits #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alankar-verma
requested review from
gallacher,
tdawe,
alikdell,
atye,
hoppea2,
chaganti-rajitha,
coulof,
meggm,
niranjan-n1,
shaynafinocchiaro,
sharmilarama,
tssushma,
taohe1012,
P-Cao,
shanmydell,
baoy1,
YianZong and
forrestxia
as code owners
adarsh-dell
approved these changes
Aug 21, 2023
|
Changes look good, but need to update branch with latest changes from release-v1.8.0 |
Done |
tdawe
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart?
No
What this PR does / why we need it:
For supporting volume limits feature in CSIPowerstore
Which issue(s) is this PR associated with:
Special notes for your reviewer:
Checklist:
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[charts_dir/mychartname]) if applicableHow Has This Been Tested?
Set maxPowerStoreVolumesPerNode to 1 in values.yaml and installed the driver
Driver installed successfully:
Env var set:
Tried to schedule 3 volumes, only 2 volumes scheduled successfully as expected: