[charts/csi-powermax] Driver images in one place #256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coulof
requested review from
gallacher,
tdawe,
alikdell,
atye,
hoppea2,
chaganti-rajitha,
meggm,
niranjan-n1,
shaynafinocchiaro,
sharmilarama,
tssushma,
taohe1012,
P-Cao,
shanmydell,
baoy1,
YianZong and
forrestxia
as code owners
coulof
changed the title
3 tasks
|
Replaced by : #309 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart?
No
What this PR does / why we need it:
This is related to the PR : dell/csi-powermax#209
Sidenote: the driver name was short (cf. https://github.com/dell/helm-charts/pull/256/files#diff-bebc208a496001a4d3afda96f7478bdaf8bf877678170d49a1bcf1b95d7ae53cR7) this seems to be a regression as OpenShift virtualization needed the provider name to be consistent with the storageclass name : https://github.com/dell/csi-powermax/blob/main/samples/storageclass/powermax.yaml#L65
Which issue(s) is this PR associated with:
Special notes for your reviewer:
Checklist:
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[charts_dir/mychartname]) if applicable